[PATCH 1/2] net: of_mdio: use int type for address variable

[PATCH 1/2] net: of_mdio: use int type for address variable

[Daniel Mack]

Use int rather than u32 to fix the following warning:

drivers/of/of_mdio.c:147 of_mdiobus_register() warn: unsigned 'addr' is
never less than zero.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Fixes: 8f8382888cba ("net: of_mdio: factor out code to parse a phy's 'reg' property")
---
David,

this patch and the next one fix warnings and build breakage reported
by Stephen and the build test system. They were both introduced by
my patches that you applied lately.

Thanks,
Daniel

 drivers/of/of_mdio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index c719601..cb36018 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -147,9 +147,8 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
 {
 	struct device_node *child;
 	const __be32 *paddr;
-	u32 addr;
 	bool scanphys = false;
-	int rc, i;
+	int addr, rc, i;
 
 	/* Mask out all PHYs from auto probing.  Instead the PHYs listed in
 	 * the device tree are populated after the bus has been registered */
-- 
1.9.0

[PATCH 2/2] of: of_mdio: export symbol of_mdiobus_link_phydev

[Daniel Mack]

Make of_mdiobus_link_phydev externally available.
This fixes CONFIG_OF_MDIO=m.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 86f6cf41272 ("net: of_mdio: add of_mdiobus_link_phydev()")
---
 drivers/of/of_mdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index cb36018..b64c258 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -240,6 +240,7 @@ void of_mdiobus_link_phydev(struct mii_bus *mdio,
 		}
 	}
 }
+EXPORT_SYMBOL(of_mdiobus_link_phydev);
 
 /* Helper function for of_phy_find_device */
 static int of_phy_match(struct device *dev, void *phy_np)
-- 
1.9.0

Re: [PATCH 2/2] of: of_mdio: export symbol of_mdiobus_link_phydev

[David Miller]

From: Daniel Mack <zonque@gmail.com>
Date: Mon,  2 Jun 2014 13:32:46 +0200

> Make of_mdiobus_link_phydev externally available.
> This fixes CONFIG_OF_MDIO=m.
> 
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 86f6cf41272 ("net: of_mdio: add of_mdiobus_link_phydev()")

Applied.

Re: [PATCH 1/2] net: of_mdio: use int type for address variable

[David Miller]

From: Daniel Mack <zonque@gmail.com>
Date: Mon,  2 Jun 2014 13:32:45 +0200

> Use int rather than u32 to fix the following warning:
> 
> drivers/of/of_mdio.c:147 of_mdiobus_register() warn: unsigned 'addr' is
> never less than zero.
> 
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Fixes: 8f8382888cba ("net: of_mdio: factor out code to parse a phy's 'reg' property")

Applied.