[PATCH 3.4] xen-netback: allow changing the MAC address of the interface

[PATCH 3.4] xen-netback: allow changing the MAC address of the interface

[Daniel Kiper]

From: Matt Wilson <msw@amazon.com>

Sometimes it is useful to be able to change the MAC address of the
interface for netback devices. For example, when using ebtables it may
be useful to be able to distinguish traffic from different interfaces
without depending on the interface name.

Reported-by: Nikita Borzykh <sample.n@gmail.com>
Reported-by: Paul Harvey <stockingpaul@hotmail.com>
Cc: netdev@vger.kernel.org
Cc: xen-devel@lists.xen.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Matt Wilson <msw@amazon.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 4a633a602c26497b8285a202830829d3be007c7b)

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Tested-by: Daniel Kiper <daniel.kiper@oracle.com>
Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 drivers/net/xen-netback/interface.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index cfaaf68..13aa5c1 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -239,6 +239,8 @@ static const struct net_device_ops xenvif_netdev_ops = {
 	.ndo_stop	= xenvif_close,
 	.ndo_change_mtu	= xenvif_change_mtu,
 	.ndo_fix_features = xenvif_fix_features,
+	.ndo_set_mac_address = eth_mac_addr,
+	.ndo_validate_addr   = eth_validate_addr,
 };
 
 struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
-- 
1.7.10.4

Re: [PATCH 3.4] xen-netback: allow changing the MAC address of the interface

[David Miller]

From: Daniel Kiper <daniel.kiper@oracle.com>
Date: Mon,  2 Jun 2014 21:46:20 +0200

> From: Matt Wilson <msw@amazon.com>
> 
> Sometimes it is useful to be able to change the MAC address of the
> interface for netback devices. For example, when using ebtables it may
> be useful to be able to distinguish traffic from different interfaces
> without depending on the interface name.
> 
> Reported-by: Nikita Borzykh <sample.n@gmail.com>
> Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> Cc: netdev@vger.kernel.org
> Cc: xen-devel@lists.xen.org
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Signed-off-by: Matt Wilson <msw@amazon.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> (cherry picked from commit 4a633a602c26497b8285a202830829d3be007c7b)
> 
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> Tested-by: Daniel Kiper <daniel.kiper@oracle.com>
> Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

I don't think this is suitable for -stable.

-stable should be restricted bug fixes for things that either
are extremely serious, or hit a very huge segment of the user
base.

This issue does not quality for either condition.

Re: [PATCH 3.4] xen-netback: allow changing the MAC address of the interface

[Greg KH]

On Thu, Jun 05, 2014 at 02:58:44PM -0700, David Miller wrote:
> From: Daniel Kiper <daniel.kiper@oracle.com>
> Date: Mon,  2 Jun 2014 21:46:20 +0200
> 
> > From: Matt Wilson <msw@amazon.com>
> > 
> > Sometimes it is useful to be able to change the MAC address of the
> > interface for netback devices. For example, when using ebtables it may
> > be useful to be able to distinguish traffic from different interfaces
> > without depending on the interface name.
> > 
> > Reported-by: Nikita Borzykh <sample.n@gmail.com>
> > Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> > Cc: netdev@vger.kernel.org
> > Cc: xen-devel@lists.xen.org
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > Signed-off-by: Matt Wilson <msw@amazon.com>
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> > (cherry picked from commit 4a633a602c26497b8285a202830829d3be007c7b)
> > 
> > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> > Tested-by: Daniel Kiper <daniel.kiper@oracle.com>
> > Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> I don't think this is suitable for -stable.
> 
> -stable should be restricted bug fixes for things that either
> are extremely serious, or hit a very huge segment of the user
> base.
> 
> This issue does not quality for either condition.

Yeah, it seems like a new feature to me, I'll drop it from my to-apply
queue.

thanks for the review,

greg k-h

Re: [PATCH 3.4] xen-netback: allow changing the MAC address of the interface

[Daniel Kiper]

On Thu, Jun 05, 2014 at 04:14:58PM -0700, Greg KH wrote:
> On Thu, Jun 05, 2014 at 02:58:44PM -0700, David Miller wrote:
> > From: Daniel Kiper <daniel.kiper@oracle.com>
> > Date: Mon,  2 Jun 2014 21:46:20 +0200
> >
> > > From: Matt Wilson <msw@amazon.com>
> > >
> > > Sometimes it is useful to be able to change the MAC address of the
> > > interface for netback devices. For example, when using ebtables it may
> > > be useful to be able to distinguish traffic from different interfaces
> > > without depending on the interface name.
> > >
> > > Reported-by: Nikita Borzykh <sample.n@gmail.com>
> > > Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> > > Cc: netdev@vger.kernel.org
> > > Cc: xen-devel@lists.xen.org
> > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > > Signed-off-by: Matt Wilson <msw@amazon.com>
> > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > Signed-off-by: David S. Miller <davem@davemloft.net>
> > > (cherry picked from commit 4a633a602c26497b8285a202830829d3be007c7b)
> > >
> > > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> > > Tested-by: Daniel Kiper <daniel.kiper@oracle.com>
> > > Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >
> > I don't think this is suitable for -stable.
> >
> > -stable should be restricted bug fixes for things that either
> > are extremely serious, or hit a very huge segment of the user
> > base.
> >
> > This issue does not quality for either condition.
>
> Yeah, it seems like a new feature to me, I'll drop it from my to-apply
> queue.

Yes, in fact it is, however, without it toolstack pollute /var/log/xen/xen-hotplug.log
with "RTNETLINK answers: Operation not supported" error when every domain is started.
Additionally, it is simple two liner and it should not break anything (Konrad and
I did some tests and everything looks OK). I do not mention that from time to time
we add some features like support for new hardware with just new device ID (e.g.
USB devices). So that is why I decided to post this patch to stable.

Daniel

Re: [PATCH 3.4] xen-netback: allow changing the MAC address of the interface

[Greg KH]

On Fri, Jun 06, 2014 at 03:04:17PM +0200, Daniel Kiper wrote:
> On Thu, Jun 05, 2014 at 04:14:58PM -0700, Greg KH wrote:
> > On Thu, Jun 05, 2014 at 02:58:44PM -0700, David Miller wrote:
> > > From: Daniel Kiper <daniel.kiper@oracle.com>
> > > Date: Mon,  2 Jun 2014 21:46:20 +0200
> > >
> > > > From: Matt Wilson <msw@amazon.com>
> > > >
> > > > Sometimes it is useful to be able to change the MAC address of the
> > > > interface for netback devices. For example, when using ebtables it may
> > > > be useful to be able to distinguish traffic from different interfaces
> > > > without depending on the interface name.
> > > >
> > > > Reported-by: Nikita Borzykh <sample.n@gmail.com>
> > > > Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> > > > Cc: netdev@vger.kernel.org
> > > > Cc: xen-devel@lists.xen.org
> > > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > > > Signed-off-by: Matt Wilson <msw@amazon.com>
> > > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > > Signed-off-by: David S. Miller <davem@davemloft.net>
> > > > (cherry picked from commit 4a633a602c26497b8285a202830829d3be007c7b)
> > > >
> > > > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> > > > Tested-by: Daniel Kiper <daniel.kiper@oracle.com>
> > > > Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > >
> > > I don't think this is suitable for -stable.
> > >
> > > -stable should be restricted bug fixes for things that either
> > > are extremely serious, or hit a very huge segment of the user
> > > base.
> > >
> > > This issue does not quality for either condition.
> >
> > Yeah, it seems like a new feature to me, I'll drop it from my to-apply
> > queue.
> 
> Yes, in fact it is, however, without it toolstack pollute /var/log/xen/xen-hotplug.log
> with "RTNETLINK answers: Operation not supported" error when every domain is started.
> Additionally, it is simple two liner and it should not break anything (Konrad and
> I did some tests and everything looks OK). I do not mention that from time to time
> we add some features like support for new hardware with just new device ID (e.g.
> USB devices). So that is why I decided to post this patch to stable.

New device ids and quirks to existing drivers are valid stable patches
(see Documentation/stable_kernel_rules.txt), but new features usually
are not.

thanks,

greg k-h

Re: [PATCH 3.4] xen-netback: allow changing the MAC address of the interface

[Daniel Kiper]

On Fri, Jun 06, 2014 at 06:56:23AM -0700, Greg KH wrote:
> On Fri, Jun 06, 2014 at 03:04:17PM +0200, Daniel Kiper wrote:
> > On Thu, Jun 05, 2014 at 04:14:58PM -0700, Greg KH wrote:
> > > On Thu, Jun 05, 2014 at 02:58:44PM -0700, David Miller wrote:
> > > > From: Daniel Kiper <daniel.kiper@oracle.com>
> > > > Date: Mon,  2 Jun 2014 21:46:20 +0200
> > > >
> > > > > From: Matt Wilson <msw@amazon.com>
> > > > >
> > > > > Sometimes it is useful to be able to change the MAC address of the
> > > > > interface for netback devices. For example, when using ebtables it may
> > > > > be useful to be able to distinguish traffic from different interfaces
> > > > > without depending on the interface name.
> > > > >
> > > > > Reported-by: Nikita Borzykh <sample.n@gmail.com>
> > > > > Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> > > > > Cc: netdev@vger.kernel.org
> > > > > Cc: xen-devel@lists.xen.org
> > > > > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > > > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > > > > Signed-off-by: Matt Wilson <msw@amazon.com>
> > > > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > > > Signed-off-by: David S. Miller <davem@davemloft.net>
> > > > > (cherry picked from commit 4a633a602c26497b8285a202830829d3be007c7b)
> > > > >
> > > > > Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> > > > > Tested-by: Daniel Kiper <daniel.kiper@oracle.com>
> > > > > Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > > >
> > > > I don't think this is suitable for -stable.
> > > >
> > > > -stable should be restricted bug fixes for things that either
> > > > are extremely serious, or hit a very huge segment of the user
> > > > base.
> > > >
> > > > This issue does not quality for either condition.
> > >
> > > Yeah, it seems like a new feature to me, I'll drop it from my to-apply
> > > queue.
> >
> > Yes, in fact it is, however, without it toolstack pollute /var/log/xen/xen-hotplug.log
> > with "RTNETLINK answers: Operation not supported" error when every domain is started.
> > Additionally, it is simple two liner and it should not break anything (Konrad and
> > I did some tests and everything looks OK). I do not mention that from time to time
> > we add some features like support for new hardware with just new device ID (e.g.
> > USB devices). So that is why I decided to post this patch to stable.
>
> New device ids and quirks to existing drivers are valid stable patches
> (see Documentation/stable_kernel_rules.txt), but new features usually
> are not.

There is something like that:
 - It must fix a problem that causes a build error (but not for things
   marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
   security issue, or some "oh, that's not good" issue.  In short,
   something critical.

I think that this is "oh, that's not good" issue type. Of course it
is not so critical but a bit annoying. Hence, could we have it in 3.4
or "NO" is your the last word in that case?

Daniel

Re: [Xen-devel] [PATCH 3.4] xen-netback: allow changing the MAC address of the interface

[Andrew Cooper]

On 06/06/14 21:02, Daniel Kiper wrote:
> On Fri, Jun 06, 2014 at 06:56:23AM -0700, Greg KH wrote:
>> On Fri, Jun 06, 2014 at 03:04:17PM +0200, Daniel Kiper wrote:
>>> On Thu, Jun 05, 2014 at 04:14:58PM -0700, Greg KH wrote:
>>>> On Thu, Jun 05, 2014 at 02:58:44PM -0700, David Miller wrote:
>>>>> From: Daniel Kiper <daniel.kiper@oracle.com>
>>>>> Date: Mon,  2 Jun 2014 21:46:20 +0200
>>>>>
>>>>>> From: Matt Wilson <msw@amazon.com>
>>>>>>
>>>>>> Sometimes it is useful to be able to change the MAC address of the
>>>>>> interface for netback devices. For example, when using ebtables it may
>>>>>> be useful to be able to distinguish traffic from different interfaces
>>>>>> without depending on the interface name.
>>>>>>
>>>>>> Reported-by: Nikita Borzykh <sample.n@gmail.com>
>>>>>> Reported-by: Paul Harvey <stockingpaul@hotmail.com>
>>>>>> Cc: netdev@vger.kernel.org
>>>>>> Cc: xen-devel@lists.xen.org
>>>>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>>>> Signed-off-by: Matt Wilson <msw@amazon.com>
>>>>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>>>> Signed-off-by: David S. Miller <davem@davemloft.net>
>>>>>> (cherry picked from commit 4a633a602c26497b8285a202830829d3be007c7b)
>>>>>>
>>>>>> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
>>>>>> Tested-by: Daniel Kiper <daniel.kiper@oracle.com>
>>>>>> Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>>> I don't think this is suitable for -stable.
>>>>>
>>>>> -stable should be restricted bug fixes for things that either
>>>>> are extremely serious, or hit a very huge segment of the user
>>>>> base.
>>>>>
>>>>> This issue does not quality for either condition.
>>>> Yeah, it seems like a new feature to me, I'll drop it from my to-apply
>>>> queue.
>>> Yes, in fact it is, however, without it toolstack pollute /var/log/xen/xen-hotplug.log
>>> with "RTNETLINK answers: Operation not supported" error when every domain is started.
>>> Additionally, it is simple two liner and it should not break anything (Konrad and
>>> I did some tests and everything looks OK). I do not mention that from time to time
>>> we add some features like support for new hardware with just new device ID (e.g.
>>> USB devices). So that is why I decided to post this patch to stable.
>> New device ids and quirks to existing drivers are valid stable patches
>> (see Documentation/stable_kernel_rules.txt), but new features usually
>> are not.
> There is something like that:
>  - It must fix a problem that causes a build error (but not for things
>    marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
>    security issue, or some "oh, that's not good" issue.  In short,
>    something critical.
>
> I think that this is "oh, that's not good" issue type. Of course it
> is not so critical but a bit annoying. Hence, could we have it in 3.4
> or "NO" is your the last word in that case?
>
> Daniel

The phrase "oh, that's not good" is usually said with a very distinctive
tone of voice, and has an habit of attracting a crowd of developers when
uttered in an office setting.

Its implied meaning is quite far from its literal meaning.

~Andrew

Re: [Xen-devel] [PATCH 3.4] xen-netback: allow changing the MAC address of the interface

[Daniel Kiper]

On Fri, Jun 06, 2014 at 09:12:20PM +0100, Andrew Cooper wrote:
> On 06/06/14 21:02, Daniel Kiper wrote:
> > On Fri, Jun 06, 2014 at 06:56:23AM -0700, Greg KH wrote:
> >> On Fri, Jun 06, 2014 at 03:04:17PM +0200, Daniel Kiper wrote:
> >>> On Thu, Jun 05, 2014 at 04:14:58PM -0700, Greg KH wrote:
> >>>> On Thu, Jun 05, 2014 at 02:58:44PM -0700, David Miller wrote:
> >>>>> From: Daniel Kiper <daniel.kiper@oracle.com>
> >>>>> Date: Mon,  2 Jun 2014 21:46:20 +0200
> >>>>>
> >>>>>> From: Matt Wilson <msw@amazon.com>
> >>>>>>
> >>>>>> Sometimes it is useful to be able to change the MAC address of the
> >>>>>> interface for netback devices. For example, when using ebtables it may
> >>>>>> be useful to be able to distinguish traffic from different interfaces
> >>>>>> without depending on the interface name.
> >>>>>>
> >>>>>> Reported-by: Nikita Borzykh <sample.n@gmail.com>
> >>>>>> Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> >>>>>> Cc: netdev@vger.kernel.org
> >>>>>> Cc: xen-devel@lists.xen.org
> >>>>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >>>>>> Signed-off-by: Matt Wilson <msw@amazon.com>
> >>>>>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>>>> Signed-off-by: David S. Miller <davem@davemloft.net>
> >>>>>> (cherry picked from commit 4a633a602c26497b8285a202830829d3be007c7b)
> >>>>>>
> >>>>>> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> >>>>>> Tested-by: Daniel Kiper <daniel.kiper@oracle.com>
> >>>>>> Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>>> I don't think this is suitable for -stable.
> >>>>>
> >>>>> -stable should be restricted bug fixes for things that either
> >>>>> are extremely serious, or hit a very huge segment of the user
> >>>>> base.
> >>>>>
> >>>>> This issue does not quality for either condition.
> >>>> Yeah, it seems like a new feature to me, I'll drop it from my to-apply
> >>>> queue.
> >>> Yes, in fact it is, however, without it toolstack pollute /var/log/xen/xen-hotplug.log
> >>> with "RTNETLINK answers: Operation not supported" error when every domain is started.
> >>> Additionally, it is simple two liner and it should not break anything (Konrad and
> >>> I did some tests and everything looks OK). I do not mention that from time to time
> >>> we add some features like support for new hardware with just new device ID (e.g.
> >>> USB devices). So that is why I decided to post this patch to stable.
> >> New device ids and quirks to existing drivers are valid stable patches
> >> (see Documentation/stable_kernel_rules.txt), but new features usually
> >> are not.
> > There is something like that:
> >  - It must fix a problem that causes a build error (but not for things
> >    marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
> >    security issue, or some "oh, that's not good" issue.  In short,
> >    something critical.
> >
> > I think that this is "oh, that's not good" issue type. Of course it
> > is not so critical but a bit annoying. Hence, could we have it in 3.4
> > or "NO" is your the last word in that case?
> >
> > Daniel
>
> The phrase "oh, that's not good" is usually said with a very distinctive
> tone of voice, and has an habit of attracting a crowd of developers when
> uttered in an office setting.
>
> Its implied meaning is quite far from its literal meaning.

Got it... ;-)))

Daniel