From: Daniel Mack <zonque@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, marek.belisko@gmail.com,
ujhelyi.m@gmail.com, Daniel Mack <zonque@gmail.com>
Subject: [PATCH 0/3] Handle stuck TX queue bug in AT8030 PHY
Date: Wed, 4 Jun 2014 11:00:36 +0200 [thread overview]
Message-ID: <1401872439-30107-1-git-send-email-zonque@gmail.com> (raw)
These three small patches circument a hardware bug in AT8030 PHYs that
leads to stuck TX FIFO queues when the link goes away while there are
pending patches in der outbound queue. This bug has been confirmed by
the vendor, and their only proposed fix is to apply a hardware reset
every time the link goes down.
I tried to fix this with a software reset routine a few months back,
but it turns out that a software reset does in fact not help here.
This new series hence makes use of the newly added way to augment
auto-probed PHY devices with DT information. This way, a 'reset-gpios'
node can be specified, and if present, the gpio will be used to reset
the PHY. In contrast to the first series I sent, this one now saves
the register contents before the reset cycle and restores them
afterwards.
I'm well aware that such a hardware reset is not a nice thing to do,
but we have to cope with hardware that leaves us no other choice.
Thanks,
Daniel
Daniel Mack (3):
net: phylib: add adjust_state callback to phy device
net: phy: at803x: use #defines for supported PHY ids
net: phy: at803x: Add support for hardware reset
drivers/net/phy/at803x.c | 119 ++++++++++++++++++++++++++++++++++++++++++++---
drivers/net/phy/phy.c | 3 ++
include/linux/phy.h | 3 ++
3 files changed, 119 insertions(+), 6 deletions(-)
--
1.9.3
next reply other threads:[~2014-06-04 9:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 9:00 Daniel Mack [this message]
2014-06-04 9:00 ` [PATCH 1/3] net: phylib: add adjust_state callback to phy device Daniel Mack
2014-06-05 5:11 ` Florian Fainelli
2014-06-05 7:14 ` Daniel Mack
2014-06-05 18:12 ` Florian Fainelli
2014-06-05 21:39 ` Daniel Mack
2014-06-04 9:00 ` [PATCH 2/3] net: phy: at803x: use #defines for supported PHY ids Daniel Mack
2014-06-04 9:00 ` [PATCH 3/3] net: phy: at803x: Add support for hardware reset Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401872439-30107-1-git-send-email-zonque@gmail.com \
--to=zonque@gmail.com \
--cc=davem@davemloft.net \
--cc=marek.belisko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ujhelyi.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).