netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: <xen-devel@lists.xen.org>, <netdev@vger.kernel.org>
Cc: <ian.campbell@citrix.com>, <david.vrabel@citrix.com>,
	<zoltan.kiss@citrix.com>, <paul.durrant@citrix.com>,
	<a.j.bennieston@gmail.com>, <wei.liu2@citrix.com>,
	"Andrew J. Bennieston" <andrew.bennieston@citrix.com>
Subject: [PATCH net-next v10 1/7] xen-netback: Move grant_copy_op array back into struct xenvif.
Date: Wed, 4 Jun 2014 10:30:41 +0100	[thread overview]
Message-ID: <1401874247-3202-2-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1401874247-3202-1-git-send-email-wei.liu2@citrix.com>

From: "Andrew J. Bennieston" <andrew.bennieston@citrix.com>

This array was allocated separately in commit ac3d5ac2 ("xen-netback:
fix guest-receive-side array sizes") due to it being very large, and a
struct xenvif is allocated as the netdev_priv part of a struct
net_device, i.e. via kmalloc() but falling back to vmalloc() if the
initial alloc. fails.

In preparation for the multi-queue patches, where this array becomes
part of struct xenvif_queue and is always allocated through vzalloc(),
move this back into the struct xenvif.

Signed-off-by: Andrew J. Bennieston <andrew.bennieston@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
---
 drivers/net/xen-netback/common.h    |    3 +--
 drivers/net/xen-netback/interface.c |    9 ---------
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h
index 0d4a285..2c283d6 100644
--- a/drivers/net/xen-netback/common.h
+++ b/drivers/net/xen-netback/common.h
@@ -158,8 +158,7 @@ struct xenvif {
 
 	struct timer_list wake_queue;
 
-	/* This array is allocated seperately as it is large */
-	struct gnttab_copy *grant_copy_op;
+	struct gnttab_copy grant_copy_op[MAX_GRANT_COPY_OPS];
 
 	/* We create one meta structure per ring request we consume, so
 	 * the maximum number is the same as the ring size.
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 53cdcdf..8fdedac 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -334,14 +334,6 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
 
 	vif = netdev_priv(dev);
 
-	vif->grant_copy_op = vmalloc(sizeof(struct gnttab_copy) *
-				     MAX_GRANT_COPY_OPS);
-	if (vif->grant_copy_op == NULL) {
-		pr_warn("Could not allocate grant copy space for %s\n", name);
-		free_netdev(dev);
-		return ERR_PTR(-ENOMEM);
-	}
-
 	vif->domid  = domid;
 	vif->handle = handle;
 	vif->can_sg = 1;
@@ -601,7 +593,6 @@ void xenvif_free(struct xenvif *vif)
 
 	unregister_netdev(vif->dev);
 
-	vfree(vif->grant_copy_op);
 	free_netdev(vif->dev);
 
 	module_put(THIS_MODULE);
-- 
1.7.10.4

  reply	other threads:[~2014-06-04  9:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04  9:30 [PATCH net-next v10 0/7] Wei Liu
2014-06-04  9:30 ` Wei Liu [this message]
2014-06-04 14:46   ` [PATCH net-next v10 1/7] xen-netback: Move grant_copy_op array back into struct xenvif Sergei Shtylyov
2014-06-04 14:52     ` David Vrabel
2014-06-04 15:00       ` Sergei Shtylyov
2014-06-04 15:03     ` Wei Liu
2014-06-04  9:30 ` [PATCH net-next v10 2/7] xen-netback: Factor queue-specific data into queue struct Wei Liu
2014-06-04  9:30 ` [PATCH net-next v10 3/7] xen-netback: Add support for multiple queues Wei Liu
2014-06-04  9:30 ` [PATCH net-next v10 4/7] xen-netfront: Factor queue-specific data into queue struct Wei Liu
2014-06-04  9:30 ` [PATCH net-next v10 5/7] xen-netfront: Add support for multiple queues Wei Liu
2014-06-04  9:30 ` [PATCH net-next v10 6/7] xen-net{back,front}: Document multi-queue feature in netif.h Wei Liu
2014-06-04  9:30 ` [PATCH net-next v10 7/7] xen-netfront: initialise queue name in xennet_init_queue Wei Liu
2014-06-04  9:35   ` Andrew J. Bennieston
2014-06-04 21:49 ` [PATCH net-next v10 0/7] David Miller
2014-06-04 22:27   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401874247-3202-2-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=a.j.bennieston@gmail.com \
    --cc=andrew.bennieston@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=netdev@vger.kernel.org \
    --cc=paul.durrant@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=zoltan.kiss@citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).