netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 06/14] i40e: clamp jumbo frame size
Date: Thu,  5 Jun 2014 00:49:19 -0700	[thread overview]
Message-ID: <1401954567-13557-7-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1401954567-13557-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Jesse Brandeburg <jesse.brandeburg@intel.com>

The driver was allowing the user to set larger size MTU
than the hardware was being configured to support.

The driver was already using VLAN_HLEN when setting the
hardware max receivable frame size, so just add it to the
netdev MTU set entry point as well.

Change-ID: Ie20e2a35d04f8c411253e255bea79ca69aaeaea3
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 2412c71..b5a8a61 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -1698,7 +1698,7 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf)
 static int i40e_change_mtu(struct net_device *netdev, int new_mtu)
 {
 	struct i40e_netdev_priv *np = netdev_priv(netdev);
-	int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN;
+	int max_frame = new_mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN;
 	struct i40e_vsi *vsi = np->vsi;
 
 	/* MTU < 68 is an error and causes problems on some kernels */
-- 
1.9.3

  parent reply	other threads:[~2014-06-05  7:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05  7:49 [net-next 00/14][pull request] Intel Wired LAN Driver Updates 2014-06-05 Jeff Kirsher
2014-06-05  7:49 ` [net-next 01/14] i40e: don't use OR to check a value Jeff Kirsher
2014-06-05  7:49 ` [net-next 02/14] i40e: Allow disabling of DCB via debugfs Jeff Kirsher
2014-06-05  7:56   ` David Miller
2014-06-05  8:05     ` Jeff Kirsher
2014-06-05  7:49 ` [net-next 03/14] i40e: Rework register diagnostic Jeff Kirsher
2014-06-05  7:49 ` [net-next 04/14] i40e: remove check for large buffer Jeff Kirsher
2014-06-05  7:49 ` [net-next 05/14] i40e/i40evf: remove unused RX_LRO define Jeff Kirsher
2014-06-05  7:49 ` Jeff Kirsher [this message]
2014-06-05  8:17   ` [net-next 06/14] i40e: clamp jumbo frame size David Laight
2014-06-05  7:49 ` [net-next 07/14] i40evf: set descriptor multiple to 32 Jeff Kirsher
2014-06-05  7:49 ` [net-next 08/14] i40evf: fix crash when changing ring sizes Jeff Kirsher
2014-06-05  7:49 ` [net-next 09/14] i40e: notify VF of all types of resets Jeff Kirsher
2014-06-05  7:49 ` [net-next 10/14] i40e/i40evf: VEB structure added, GTIME macro update Jeff Kirsher
2014-06-05  7:49 ` [net-next 11/14] i40e: refactor send version Jeff Kirsher
2014-06-05  7:49 ` [net-next 12/14] i40e: refactor stats collection Jeff Kirsher
2014-06-05  7:49 ` [net-next 13/14] i40e/i40evf: remove rx_errors and rx_missed Jeff Kirsher
2014-06-05  7:49 ` [net-next 14/14] i40e: add missing VSI statistics Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401954567-13557-7-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).