From: Alexander Stein <alexander.stein@systec-electronic.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>,
netdev@vger.kernel.org,
Alexander Stein <alexander.stein@systec-electronic.com>
Subject: [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe
Date: Thu, 5 Jun 2014 10:53:02 +0200 [thread overview]
Message-ID: <1401958387-8154-1-git-send-email-alexander.stein@systec-electronic.com> (raw)
From: Daniel Krueger <daniel.krueger@systec-electronic.com>
It is also neat to show the actual offending MAC address instead of just
rejecting it
Signed-off-by: Daniel Krueger <daniel.krueger@systec-electronic.com>
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
Changes in v2:
* Use just a single line
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index 73e6683..cf3101c 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -2672,8 +2672,7 @@ static int pch_gbe_probe(struct pci_dev *pdev,
* prevent the interface from being brought up until a valid MAC
* is set.
*/
- dev_err(&pdev->dev, "Invalid MAC address, "
- "interface disabled.\n");
+ dev_err(&pdev->dev, "Invalid MAC address %pM - interface disabled.\n", adapter->hw.mac.addr);
}
setup_timer(&adapter->watchdog_timer, pch_gbe_watchdog,
(unsigned long)adapter);
--
1.8.5.5
next reply other threads:[~2014-06-05 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 8:53 Alexander Stein [this message]
2014-06-05 8:53 ` [PATCH v2 2/6] pch_gbe: Add module parameter for RGMII/GMII PHY mode selection Alexander Stein
2014-06-05 18:15 ` Florian Fainelli
2014-06-05 8:53 ` [PATCH v2 3/6] pch_gbe: change order of PHY address discovering Alexander Stein
2014-06-05 8:53 ` [PATCH v2 4/6] pch_gbe: remove unnecessary PHY resets Alexander Stein
2014-06-05 8:53 ` [PATCH v2 5/6] pch_gbe: reset PHY before first configuration Alexander Stein
2014-06-05 8:53 ` [PATCH v2 6/6] pch_gbe: remove shutdown and restart of interface after PHY settings change Alexander Stein
2014-06-05 18:00 ` [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe Florian Fainelli
2014-06-05 22:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401958387-8154-1-git-send-email-alexander.stein@systec-electronic.com \
--to=alexander.stein@systec-electronic.com \
--cc=daniel.krueger@systec-electronic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).