From: Alexander Stein <alexander.stein@systec-electronic.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Daniel Krueger <daniel.krueger@systec-electronic.com>,
netdev@vger.kernel.org,
Alexander Stein <alexander.stein@systec-electronic.com>
Subject: [PATCH v2 4/6] pch_gbe: remove unnecessary PHY resets
Date: Thu, 5 Jun 2014 10:53:05 +0200 [thread overview]
Message-ID: <1401958387-8154-4-git-send-email-alexander.stein@systec-electronic.com> (raw)
In-Reply-To: <1401958387-8154-1-git-send-email-alexander.stein@systec-electronic.com>
From: Daniel Krueger <daniel.krueger@systec-electronic.com>
Those PHY software resets destroy the painfully made PHY settings.
Signed-off-by: Daniel Krueger <daniel.krueger@systec-electronic.com>
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | 2 --
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c
index 826f0cc..fbfac98 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c
@@ -111,8 +111,6 @@ static int pch_gbe_set_settings(struct net_device *netdev,
u32 speed = ethtool_cmd_speed(ecmd);
int ret;
- pch_gbe_hal_write_phy_reg(hw, MII_BMCR, BMCR_RESET);
-
/* when set_settings() is called with a ethtool_cmd previously
* filled by get_settings() on a down link, speed is -1: */
if (speed == UINT_MAX) {
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
index a5cad5e..3fa9a8f 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
@@ -320,7 +320,6 @@ void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw)
cmd.duplex = hw->mac.link_duplex;
cmd.advertising = hw->phy.autoneg_advertised;
cmd.autoneg = hw->mac.autoneg;
- pch_gbe_phy_write_reg_miic(hw, MII_BMCR, BMCR_RESET);
ret = mii_ethtool_sset(&adapter->mii, &cmd);
if (ret)
netdev_err(adapter->netdev, "Error: mii_ethtool_sset\n");
--
1.8.5.5
next prev parent reply other threads:[~2014-06-05 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 8:53 [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe Alexander Stein
2014-06-05 8:53 ` [PATCH v2 2/6] pch_gbe: Add module parameter for RGMII/GMII PHY mode selection Alexander Stein
2014-06-05 18:15 ` Florian Fainelli
2014-06-05 8:53 ` [PATCH v2 3/6] pch_gbe: change order of PHY address discovering Alexander Stein
2014-06-05 8:53 ` Alexander Stein [this message]
2014-06-05 8:53 ` [PATCH v2 5/6] pch_gbe: reset PHY before first configuration Alexander Stein
2014-06-05 8:53 ` [PATCH v2 6/6] pch_gbe: remove shutdown and restart of interface after PHY settings change Alexander Stein
2014-06-05 18:00 ` [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe Florian Fainelli
2014-06-05 22:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401958387-8154-4-git-send-email-alexander.stein@systec-electronic.com \
--to=alexander.stein@systec-electronic.com \
--cc=daniel.krueger@systec-electronic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).