From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net-next 4/4] net: systemport: start with carrier off
Date: Thu, 5 Jun 2014 10:22:18 -0700 [thread overview]
Message-ID: <1401988938-25940-5-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1401988938-25940-1-git-send-email-f.fainelli@gmail.com>
The SYSTEMPORT driver uses libphy to determine the carrier state, so
make sure we start with a carrier off until libphy has completed the
link training process.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/bcmsysport.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index 54b51db0caf3..141160ef249a 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -1595,6 +1595,9 @@ static int bcm_sysport_probe(struct platform_device *pdev)
*/
dev->flags &= ~IFF_MULTICAST;
+ /* libphy will adjust the link state accordingly */
+ netif_carrier_off(dev);
+
ret = register_netdev(dev);
if (ret) {
dev_err(&pdev->dev, "failed to register net_device\n");
--
1.9.1
next prev parent reply other threads:[~2014-06-05 17:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 17:22 [PATCH net-next 0/4] net: systemport: misc fixes Florian Fainelli
2014-06-05 17:22 ` [PATCH net-next 1/4] net: systemport: fix transmit locking scheme Florian Fainelli
2014-06-06 9:29 ` David Laight
2014-06-06 17:00 ` Florian Fainelli
2014-06-05 17:22 ` [PATCH net-next 2/4] net: systemport: correctly check for RX_STATUS_OVFLOW flag Florian Fainelli
2014-06-05 17:22 ` [PATCH net-next 3/4] net: systemport: fix comment about HW prepending 2bytes Florian Fainelli
2014-06-05 17:22 ` Florian Fainelli [this message]
2014-06-05 22:37 ` [PATCH net-next 0/4] net: systemport: misc fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401988938-25940-5-git-send-email-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).