Re: [net-next 04/15] i40evf: remove unnecessary log messages

[Joe Perches <joe@perches.com>]

On Sun, 2014-06-08 at 07:33 -0700, Jeff Kirsher wrote:
> From: Mitch Williams <mitch.a.williams@intel.com>

A slightly associated trivial note:

One day it'd be nicer to use the same "if (!foo)"
test style everywhere.

> diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
[]
> @@ -662,12 +661,9 @@ i40evf_vlan_filter *i40evf_add_vlan(struct i40evf_adapter *adapter, u16 vlan)
[]
>  		f = kzalloc(sizeof(*f), GFP_ATOMIC);
> -		if (NULL == f) {
> -			dev_info(&adapter->pdev->dev,
> -				 "%s: no memory for new VLAN filter\n",
> -				 __func__);
> +		if (NULL == f)
>  			return NULL;
> -		}
> +

[]

> @@ -1610,11 +1603,9 @@ static void i40evf_adminq_task(struct work_struct *work)
>  
>  	event.msg_size = I40EVF_MAX_AQ_BUF_SIZE;
>  	event.msg_buf = kzalloc(event.msg_size, GFP_KERNEL);
> -	if (!event.msg_buf) {
> -		dev_info(&adapter->pdev->dev, "%s: no memory for ARQ clean\n",
> -				 __func__);
> +	if (!event.msg_buf)
>  		return;
> -	}
> +