From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [Xen-devel] [PATCH] net: xen-netback: include linux/vmalloc.h again Date: Tue, 10 Jun 2014 09:52:36 +0100 Message-ID: <1402390356.29980.3.camel@kazak.uk.xensource.com> References: <5508988.K5Wec8A6hA@wuerfel> <20140610084454.GB28084@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Arnd Bergmann , Josh Boyer , , , "Andrew J. Bennieston" , David Miller To: Wei Liu Return-path: Received: from smtp.citrix.com ([66.165.176.89]:60765 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbaFJIwo (ORCPT ); Tue, 10 Jun 2014 04:52:44 -0400 In-Reply-To: <20140610084454.GB28084@zion.uk.xensource.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2014-06-10 at 09:44 +0100, Wei Liu wrote: > On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote: > > commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into > > queue struct") added a use of vzalloc/vfree to interface.c, but > > removed the #include statement at the same time, > > which causes this build error: > > > > drivers/net/xen-netback/interface.c: In function 'xenvif_free': > > drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] > > vfree(vif->queues); > > ^ > > cc1: some warnings being treated as errors > > > > Signed-off-by: Arnd Bergmann > > Cc: Wei Liu > > Cc: Andrew J. Bennieston > > Acked-by: Wei Liu > > This didn't happen to me when I built it on x86 though. Just curious, > did you build it on othet platform, say, ARM? Arnd comaintains the arm-soc tree, so that's a pretty good bet ;-) Ian.