From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Or Gerlitz <or.gerlitz@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [net-next 12/15] i40e: remove Tx work for ptp
Date: Wed, 11 Jun 2014 13:56:42 -0700 [thread overview]
Message-ID: <1402520202.2336.7.camel@jtkirshe-mobl> (raw)
In-Reply-To: <CAJZOPZJRjZ+od4-obYJfGbzTT0W1nRfCZvWeWa1VZbTD2vLdTQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
On Tue, 2014-05-27 at 10:51 +0300, Or Gerlitz wrote:
> On Wed, May 21, 2014 at 3:01 PM, Jeff Kirsher
> <jeffrey.t.kirsher@intel.com> wrote:
> >
> > From: Jesse Brandeburg <jesse.brandeburg@intel.com>
> >
> > The previous removal of the PTP Tx work functionality was
> > incomplete as noted by Jake Keller. This removal allows
> > us to rely on the Tx timesync interrupt.
>
> This patch removes a define of I40E_PTP_TX_TIMEOUT and stats entry
> for
> tx_hwtstamp_timeouts, I am not sure to see how this removal allows the
> driver to
> rely on the Tx timesync interrupt, maybe wrong change-log?
Sorry, you are correct it was change-log mistake. This was follow on to
the previous:
Commit 0dd8357f8fab1d82aa8fc8267261203f393d5a1f
Author: Jacob Keller
Date: Wed Jan 15 08:38:35 2014 +0000
i40e: remove ptp_tx_work timestamp work item
which implemented the work to allow us to rely on the Tx timesync
interrupt. This patch was just finishing up the cleanup of code which
we did not need any longer because of the conversion to the transmit
timesync interrupt.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-06-11 20:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 12:00 [net-next 00/15][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-05-21 12:00 ` [net-next 01/15] i40evf: Update AdminQ interface Jeff Kirsher
2014-05-21 12:01 ` [net-next 02/15] i40evf: Remove unused defines Jeff Kirsher
2014-05-21 12:01 ` [net-next 03/15] i40evf: Fix the headers and update copyright year Jeff Kirsher
2014-05-21 12:01 ` [net-next 04/15] i40e: add required include Jeff Kirsher
2014-05-21 12:01 ` [net-next 05/15] i40evf: Use macro param for ethtool stats Jeff Kirsher
2014-05-21 12:01 ` [net-next 06/15] i40evf: don't lie to ethtool Jeff Kirsher
2014-05-21 12:01 ` [net-next 07/15] i40evf: make ethtool_ops const Jeff Kirsher
2014-05-21 12:01 ` [net-next 08/15] i40e/i40evf: set proper default for ITR registers Jeff Kirsher
2014-05-21 12:01 ` [net-next 09/15] i40e/i40evf: control auto ITR through ethtool Jeff Kirsher
2014-05-21 12:01 ` [net-next 10/15] i40e: remove hardcode of stats struct size in ethtool Jeff Kirsher
2014-05-21 12:01 ` [net-next 11/15] i40e: Don't disable SR-IOV when VFs are assigned Jeff Kirsher
2014-05-21 12:01 ` [net-next 12/15] i40e: remove Tx work for ptp Jeff Kirsher
2014-05-27 7:51 ` Or Gerlitz
2014-06-11 20:56 ` Jeff Kirsher [this message]
2014-05-21 12:01 ` [net-next 13/15] i40e: Check PCI_IOV config to avoid compile error Jeff Kirsher
2014-05-21 12:01 ` [net-next 14/15] i40evf: Use pci_enable_msix_range() instead of pci_enable_msix() Jeff Kirsher
2014-05-21 12:01 ` [net-next 15/15] i40e: fix passing wrong error code to i40e_open() Jeff Kirsher
2014-05-22 16:05 ` [net-next 00/15][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402520202.2336.7.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).