From: Alex <d77190@mail.ru>
To: Cong Wang <cwang@twopensource.com>
Cc: netdev@vger.kernel.org
Subject: Re: Bug 75571
Date: Sun, 15 Jun 2014 02:29:32 +0700 [thread overview]
Message-ID: <1402774172.29664.27.camel@anpws> (raw)
In-Reply-To: <CAHA+R7Nnm0ueWPKYYT0M1Nn8DOcKcRiDG6-Py+OcNgvvnqO2Ng@mail.gmail.com>
> The best thing we can try is to fix it dynamically on rx, something
> like below (if you want to try this patch, please revert the previous one):
>
> diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c
> index 5dc5137..5eff109 100644
> --- a/net/ipv4/ipip.c
> +++ b/net/ipv4/ipip.c
> @@ -407,6 +407,7 @@ static int ipip_rcv(struct sk_buff *skb)
> tstats->rx_packets++;
> tstats->rx_bytes += skb->len;
>
> + tunnel->dev->hard_header_len = skb->data - skb_mac_header(skb);
> __skb_tunnel_rx(skb, tunnel->dev);
>
> ipip_ecn_decapsulate(iph, skb);
Thank you! This patch works too.
But I think both patches are valid: act_mirred must not panic on
receiving bad header len and ipip tunnel should not send incorrect
header len too.
prev parent reply other threads:[~2014-06-14 19:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 6:20 Bug 75571 Alex
2014-06-01 14:43 ` Emil Goode
2014-06-02 10:32 ` Alex
2014-06-02 17:38 ` Cong Wang
2014-06-02 21:19 ` Cong Wang
2014-06-04 8:31 ` Alex
2014-06-05 0:27 ` Cong Wang
2014-06-05 5:22 ` Alex
2014-06-05 19:18 ` Cong Wang
2014-06-06 4:13 ` Alex
2014-06-09 23:49 ` Cong Wang
2014-06-14 19:29 ` Alex [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402774172.29664.27.camel@anpws \
--to=d77190@mail.ru \
--cc=cwang@twopensource.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox