* [PATCH 1/1] drivers/net/irda/kingsun-sir.c: remove null test before kfree
@ 2014-06-17 19:22 Fabian Frederick
2014-06-20 4:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-17 19:22 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Samuel Ortiz, netdev
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required
Cc: Samuel Ortiz <samuel@sortiz.org>
Cc: netdev@vger.kernel.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/irda/kingsun-sir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/irda/kingsun-sir.c b/drivers/net/irda/kingsun-sir.c
index 96fe365..e638893 100644
--- a/drivers/net/irda/kingsun-sir.c
+++ b/drivers/net/irda/kingsun-sir.c
@@ -553,8 +553,8 @@ static int kingsun_probe(struct usb_interface *intf,
return 0;
free_mem:
- if (kingsun->out_buf) kfree(kingsun->out_buf);
- if (kingsun->in_buf) kfree(kingsun->in_buf);
+ kfree(kingsun->out_buf);
+ kfree(kingsun->in_buf);
free_netdev(net);
err_out1:
return ret;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drivers/net/irda/kingsun-sir.c: remove null test before kfree
2014-06-17 19:22 [PATCH 1/1] drivers/net/irda/kingsun-sir.c: remove null test before kfree Fabian Frederick
@ 2014-06-20 4:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-06-20 4:26 UTC (permalink / raw)
To: fabf; +Cc: linux-kernel, samuel, netdev
From: Fabian Frederick <fabf@skynet.be>
Date: Tue, 17 Jun 2014 21:22:50 +0200
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Samuel Ortiz <samuel@sortiz.org>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-20 4:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-17 19:22 [PATCH 1/1] drivers/net/irda/kingsun-sir.c: remove null test before kfree Fabian Frederick
2014-06-20 4:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).