From: Daniel Mack <zonque@gmail.com>
To: netdev@vger.kernel.org, f.fainelli@gmail.com
Cc: davem@davemloft.net, marek.belisko@gmail.com,
ujhelyi.m@gmail.com, Daniel Mack <zonque@gmail.com>
Subject: [PATCH v2 1/3] net: phylib: add link_change_notify callback to phy device
Date: Wed, 18 Jun 2014 11:01:41 +0200 [thread overview]
Message-ID: <1403082103-23709-2-git-send-email-zonque@gmail.com> (raw)
In-Reply-To: <1403082103-23709-1-git-send-email-zonque@gmail.com>
Add a notify callback to inform phy drivers when the core is about to
do its link adjustment. No change for drivers that do not implement
this callback.
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
drivers/net/phy/phy.c | 3 +++
include/linux/phy.h | 9 +++++++++
2 files changed, 12 insertions(+)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 3bc079a..f7c6181 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -720,6 +720,9 @@ void phy_state_machine(struct work_struct *work)
mutex_lock(&phydev->lock);
+ if (phydev->drv->link_change_notify)
+ phydev->drv->link_change_notify(phydev);
+
switch (phydev->state) {
case PHY_DOWN:
case PHY_STARTING:
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 51d15f6..54b8723 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -529,6 +529,15 @@ struct phy_driver {
/* See set_wol, but for checking whether Wake on LAN is enabled. */
void (*get_wol)(struct phy_device *dev, struct ethtool_wolinfo *wol);
+ /*
+ * Called to inform a PHY device driver when the core is about to
+ * change the link state. This callback is supposed to be used as
+ * fixup hook for drivers that need to take action when the link
+ * state changes. Drivers are by no means allowed to mess with the
+ * PHY device structure in their implementations.
+ */
+ void (*link_change_notify)(struct phy_device *dev);
+
struct device_driver driver;
};
#define to_phy_driver(d) container_of(d, struct phy_driver, driver)
--
1.9.3
next prev parent reply other threads:[~2014-06-18 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 9:01 [PATCH v2 0/3] Handle stuck TX queue bug in AT8030 PHY Daniel Mack
2014-06-18 9:01 ` Daniel Mack [this message]
2014-06-18 9:01 ` [PATCH v2 2/3] net: phy: at803x: use #defines for supported PHY ids Daniel Mack
2014-06-18 9:01 ` [PATCH v2 3/3] net: phy: at803x: Add support for hardware reset Daniel Mack
2014-06-21 22:51 ` [PATCH v2 0/3] Handle stuck TX queue bug in AT8030 PHY David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403082103-23709-2-git-send-email-zonque@gmail.com \
--to=zonque@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=marek.belisko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ujhelyi.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).