From: Daniel Mack <zonque@gmail.com>
To: netdev@vger.kernel.org, f.fainelli@gmail.com
Cc: davem@davemloft.net, marek.belisko@gmail.com,
ujhelyi.m@gmail.com, Daniel Mack <zonque@gmail.com>
Subject: [PATCH v2 2/3] net: phy: at803x: use #defines for supported PHY ids
Date: Wed, 18 Jun 2014 11:01:42 +0200 [thread overview]
Message-ID: <1403082103-23709-3-git-send-email-zonque@gmail.com> (raw)
In-Reply-To: <1403082103-23709-1-git-send-email-zonque@gmail.com>
This removes magic values from two tables and also allows us to match
against specific PHY models at runtime.
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
drivers/net/phy/at803x.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index b256083..045e446 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -35,6 +35,10 @@
#define AT803X_DEBUG_SYSTEM_MODE_CTRL 0x05
#define AT803X_DEBUG_RGMII_TX_CLK_DLY BIT(8)
+#define ATH8030_PHY_ID 0x004dd076
+#define ATH8031_PHY_ID 0x004dd074
+#define ATH8035_PHY_ID 0x004dd072
+
MODULE_DESCRIPTION("Atheros 803x PHY driver");
MODULE_AUTHOR("Matus Ujhelyi");
MODULE_LICENSE("GPL");
@@ -192,7 +196,7 @@ static int at803x_config_intr(struct phy_device *phydev)
static struct phy_driver at803x_driver[] = {
{
/* ATHEROS 8035 */
- .phy_id = 0x004dd072,
+ .phy_id = ATH8035_PHY_ID,
.name = "Atheros 8035 ethernet",
.phy_id_mask = 0xffffffef,
.config_init = at803x_config_init,
@@ -209,7 +213,7 @@ static struct phy_driver at803x_driver[] = {
},
}, {
/* ATHEROS 8030 */
- .phy_id = 0x004dd076,
+ .phy_id = ATH8030_PHY_ID,
.name = "Atheros 8030 ethernet",
.phy_id_mask = 0xffffffef,
.config_init = at803x_config_init,
@@ -226,7 +230,7 @@ static struct phy_driver at803x_driver[] = {
},
}, {
/* ATHEROS 8031 */
- .phy_id = 0x004dd074,
+ .phy_id = ATH8031_PHY_ID,
.name = "Atheros 8031 ethernet",
.phy_id_mask = 0xffffffef,
.config_init = at803x_config_init,
@@ -261,9 +265,9 @@ module_init(atheros_init);
module_exit(atheros_exit);
static struct mdio_device_id __maybe_unused atheros_tbl[] = {
- { 0x004dd076, 0xffffffef },
- { 0x004dd074, 0xffffffef },
- { 0x004dd072, 0xffffffef },
+ { ATH8030_PHY_ID, 0xffffffef },
+ { ATH8031_PHY_ID, 0xffffffef },
+ { ATH8035_PHY_ID, 0xffffffef },
{ }
};
--
1.9.3
next prev parent reply other threads:[~2014-06-18 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 9:01 [PATCH v2 0/3] Handle stuck TX queue bug in AT8030 PHY Daniel Mack
2014-06-18 9:01 ` [PATCH v2 1/3] net: phylib: add link_change_notify callback to phy device Daniel Mack
2014-06-18 9:01 ` Daniel Mack [this message]
2014-06-18 9:01 ` [PATCH v2 3/3] net: phy: at803x: Add support for hardware reset Daniel Mack
2014-06-21 22:51 ` [PATCH v2 0/3] Handle stuck TX queue bug in AT8030 PHY David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403082103-23709-3-git-send-email-zonque@gmail.com \
--to=zonque@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=marek.belisko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ujhelyi.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).