From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Mitch Williams <mitch.a.williams@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 10/13] i40evf: fix off-by-one
Date: Fri, 20 Jun 2014 00:49:45 -0700 [thread overview]
Message-ID: <1403250588-14356-11-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1403250588-14356-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Mitch Williams <mitch.a.williams@intel.com>
The loop in i40evf_get_rxfh_indir was only reading fifteen registers,
not all sixteen. Change the matching loop in i40evf_set_rxfh_indir at
the same time to make the code more consistent.
Change-ID: I6c182287698e742d1f6ca1a4bcc43cc08df6e1de
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c
index 60407a9..e70e4cd 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c
@@ -632,7 +632,7 @@ static int i40evf_get_rxfh(struct net_device *netdev, u32 *indir, u8 *key)
u32 hlut_val;
int i, j;
- for (i = 0, j = 0; i < I40E_VFQF_HLUT_MAX_INDEX; i++) {
+ for (i = 0, j = 0; i <= I40E_VFQF_HLUT_MAX_INDEX; i++) {
hlut_val = rd32(hw, I40E_VFQF_HLUT(i));
indir[j++] = hlut_val & 0xff;
indir[j++] = (hlut_val >> 8) & 0xff;
@@ -659,7 +659,7 @@ static int i40evf_set_rxfh(struct net_device *netdev, const u32 *indir,
u32 hlut_val;
int i, j;
- for (i = 0, j = 0; i < I40E_VFQF_HLUT_MAX_INDEX + 1; i++) {
+ for (i = 0, j = 0; i <= I40E_VFQF_HLUT_MAX_INDEX; i++) {
hlut_val = indir[j++];
hlut_val |= indir[j++] << 8;
hlut_val |= indir[j++] << 16;
--
1.9.3
next prev parent reply other threads:[~2014-06-20 7:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 7:49 [net-next 00/13][pull request] Intel Wired LAN Driver Updates 2014-06-20 Jeff Kirsher
2014-06-20 7:49 ` [net-next 01/13] i40e/i40evf: i40e_register.h update Jeff Kirsher
2014-06-20 9:07 ` Bjørn Mork
2014-06-20 9:57 ` Jeff Kirsher
2014-06-20 7:49 ` [net-next 02/13] i40e: workaround NVM GLQF_HKEY Jeff Kirsher
2014-06-20 7:49 ` [net-next 03/13] i40e/i40evf: Reset Head and Tail on AQ initialization Jeff Kirsher
2014-06-20 7:49 ` [net-next 04/13] i40e: Fix dangling ring pointers upon driver removal Jeff Kirsher
2014-06-20 7:49 ` [net-next 05/13] i40e: Helper routine for Rx/Tx queue enable/disable wait Jeff Kirsher
2014-06-20 7:49 ` [net-next 06/13] i40e: debugfs fix to dump remote LLDPDU Jeff Kirsher
2014-06-20 7:49 ` [net-next 07/13] i40e: Fix scheduling while atomic bug during NAPI Jeff Kirsher
2014-06-20 7:49 ` [net-next 08/13] i40e: clear VEB stats when pf stats are cleared Jeff Kirsher
2014-06-20 7:49 ` [net-next 09/13] i40e: keep service tasks out of reset process Jeff Kirsher
2014-06-20 7:49 ` Jeff Kirsher [this message]
2014-06-20 7:49 ` [net-next 11/13] i40e/i40evf: Update RSS configuration Jeff Kirsher
2014-06-20 7:49 ` [net-next 12/13] i40e/i40evf: modify debug prints to avoid seg faults Jeff Kirsher
2014-06-20 7:49 ` [net-next 13/13] i40e/i40evf: Bump i40e to 0.4.13 and i40evf to 0.9.35 Jeff Kirsher
2014-06-21 22:00 ` [net-next 00/13][pull request] Intel Wired LAN Driver Updates 2014-06-20 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403250588-14356-11-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).