From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Anjali Singhai Jain <anjali.singhai@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 04/13] i40e: Fix dangling ring pointers upon driver removal
Date: Fri, 20 Jun 2014 00:49:39 -0700 [thread overview]
Message-ID: <1403250588-14356-5-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1403250588-14356-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Anjali Singhai Jain <anjali.singhai@intel.com>
When we resize the number of queues, the driver needs to disassociate any
qvectors that are no longer in use from the original rings, this way we
do not try to access the rings through these qvectors at the time of freeing
the qvectors.
Change-ID: Ie4eb9fc749f8e12348517fe1560f599c58f4a2a4
Signed-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 95c331a..7d2aeeb 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -3151,8 +3151,12 @@ static void i40e_vsi_map_rings_to_vectors(struct i40e_vsi *vsi)
/* If we don't have enough vectors for a 1-to-1 mapping, we'll have to
* group them so there are multiple queues per vector.
+ * It is also important to go through all the vectors available to be
+ * sure that if we don't use all the vectors, that the remaining vectors
+ * are cleared. This is especially important when decreasing the
+ * number of queues in use.
*/
- for (; v_start < q_vectors && qp_remaining; v_start++) {
+ for (; v_start < q_vectors; v_start++) {
struct i40e_q_vector *q_vector = vsi->q_vectors[v_start];
num_ringpairs = DIV_ROUND_UP(qp_remaining, q_vectors - v_start);
--
1.9.3
next prev parent reply other threads:[~2014-06-20 7:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 7:49 [net-next 00/13][pull request] Intel Wired LAN Driver Updates 2014-06-20 Jeff Kirsher
2014-06-20 7:49 ` [net-next 01/13] i40e/i40evf: i40e_register.h update Jeff Kirsher
2014-06-20 9:07 ` Bjørn Mork
2014-06-20 9:57 ` Jeff Kirsher
2014-06-20 7:49 ` [net-next 02/13] i40e: workaround NVM GLQF_HKEY Jeff Kirsher
2014-06-20 7:49 ` [net-next 03/13] i40e/i40evf: Reset Head and Tail on AQ initialization Jeff Kirsher
2014-06-20 7:49 ` Jeff Kirsher [this message]
2014-06-20 7:49 ` [net-next 05/13] i40e: Helper routine for Rx/Tx queue enable/disable wait Jeff Kirsher
2014-06-20 7:49 ` [net-next 06/13] i40e: debugfs fix to dump remote LLDPDU Jeff Kirsher
2014-06-20 7:49 ` [net-next 07/13] i40e: Fix scheduling while atomic bug during NAPI Jeff Kirsher
2014-06-20 7:49 ` [net-next 08/13] i40e: clear VEB stats when pf stats are cleared Jeff Kirsher
2014-06-20 7:49 ` [net-next 09/13] i40e: keep service tasks out of reset process Jeff Kirsher
2014-06-20 7:49 ` [net-next 10/13] i40evf: fix off-by-one Jeff Kirsher
2014-06-20 7:49 ` [net-next 11/13] i40e/i40evf: Update RSS configuration Jeff Kirsher
2014-06-20 7:49 ` [net-next 12/13] i40e/i40evf: modify debug prints to avoid seg faults Jeff Kirsher
2014-06-20 7:49 ` [net-next 13/13] i40e/i40evf: Bump i40e to 0.4.13 and i40evf to 0.9.35 Jeff Kirsher
2014-06-21 22:00 ` [net-next 00/13][pull request] Intel Wired LAN Driver Updates 2014-06-20 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403250588-14356-5-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=anjali.singhai@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).