Re: [net-next 01/13] i40e/i40evf: i40e_register.h update

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On Fri, 2014-06-20 at 11:07 +0200, Bjørn Mork wrote:
> Jeff Kirsher <jeffrey.t.kirsher@intel.com> writes:
> 
> >  drivers/net/ethernet/intel/i40e/i40e_main.c       |   30 +-
> >  drivers/net/ethernet/intel/i40e/i40e_register.h   | 5011
> ++++++++-------------
> >  drivers/net/ethernet/intel/i40e/i40e_type.h       |    3 +
> >  drivers/net/ethernet/intel/i40evf/i40e_register.h | 5011
> ++++++++-------------
> >  drivers/net/ethernet/intel/i40evf/i40e_type.h     |    3 +
> >  5 files changed, 3728 insertions(+), 6330 deletions(-)
> 
> Not really a comment on this patch, but the diffstat above made me
> suspect that you have lots of duplicates here...  Does it *really*
> make
> sense to maintain syncronized copies of these rather large header
> files,
> just because a total of 3 lines are different (not counting the
> unneccessary header diff and the assumed unwanted whitespace diff)?

We have been discussing this internally to come up with a solution and
one of the big reasons why we have not made the common code into a
shared resource for both drivers has been due to regression issues.  But
we are currently actively looking into what can be done to minimize this
type of duplication.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]