netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Octavian Purdila <octavian.purdila@intel.com>
To: netdev@vger.kernel.org
Cc: Octavian Purdila <octavian.purdila@intel.com>
Subject: [RFC net-next 00/12] remove code duplication in tcp_v[46]_conn_request
Date: Mon, 23 Jun 2014 21:42:37 +0300	[thread overview]
Message-ID: <1403548969-12303-1-git-send-email-octavian.purdila@intel.com> (raw)

This patch series removes code duplication in tcp_v4_conn_request and
tcp_v6_conn_request by adding a few new methods in
tcp_request_sock_ops.

Since this can potentially have performance impact I will later come
back with some benchmarks results for before and after -- I am
thinking that connections per second tests should cover it.

In the meanwhile, any feedback on the approach is kindly appreciated.

The first 3 patches are cleanups and fixes found during the code merge
process, which shows that having a single tcp_conn_request function is
useful to avoid future issues.

Octavian Purdila (12):
  tcp: cookie_v4_init_sequence: skb should be const
  tcp: tcp_v[46]_conn_request: fix snt_synack initialization
  net: remove inet6_reqsk_alloc
  tcp: add init_req method to tcp_request_sock_ops
  tcp: add init_cookie_seq method to tcp_request_sock_ops
  tcp: add route_req method to tcp_request_sock_ops
  tcp: move around a few calls in tcp_v6_conn_request
  tcp: add init_seq method to tcp_request_sock_ops
  tcp: add send_synack method to tcp_request_sock_ops
  tcp: unify tcp_v4_rtx_synack and tcp_v6_rtx_synack
  tcp: add mss_clamp to tcp_request_sock_ops
  tcp: add tcp_conn_request

 include/linux/ipv6.h    |  10 ---
 include/linux/tcp.h     |   3 -
 include/net/inet_sock.h |   6 +-
 include/net/tcp.h       |  52 +++++++++----
 net/dccp/ipv6.c         |   2 +-
 net/ipv4/syncookies.c   |   3 +-
 net/ipv4/tcp_input.c    | 148 +++++++++++++++++++++++++++++++++++
 net/ipv4/tcp_ipv4.c     | 188 +++++++++++---------------------------------
 net/ipv4/tcp_output.c   |  15 ++++
 net/ipv6/syncookies.c   |   2 +-
 net/ipv6/tcp_ipv6.c     | 202 +++++++++++++-----------------------------------
 11 files changed, 303 insertions(+), 328 deletions(-)

-- 
1.8.3.2

             reply	other threads:[~2014-06-23 18:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 18:42 Octavian Purdila [this message]
2014-06-23 18:42 ` [RFC net-next 01/12] tcp: cookie_v4_init_sequence: skb should be const Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 02/12] tcp: tcp_v[46]_conn_request: fix snt_synack initialization Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 03/12] net: remove inet6_reqsk_alloc Octavian Purdila
2014-06-25 23:17   ` David Miller
2014-06-26 15:13     ` Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 04/12] tcp: add init_req method to tcp_request_sock_ops Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 05/12] tcp: add init_cookie_seq " Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 06/12] tcp: add route_req " Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 07/12] tcp: move around a few calls in tcp_v6_conn_request Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 08/12] tcp: add init_seq method to tcp_request_sock_ops Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 09/12] tcp: add send_synack " Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 10/12] tcp: unify tcp_v4_rtx_synack and tcp_v6_rtx_synack Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 11/12] tcp: add mss_clamp to tcp_request_sock_ops Octavian Purdila
2014-06-23 18:42 ` [RFC net-next 12/12] tcp: add tcp_conn_request Octavian Purdila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403548969-12303-1-git-send-email-octavian.purdila@intel.com \
    --to=octavian.purdila@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).