netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Octavian Purdila <octavian.purdila@intel.com>
To: netdev@vger.kernel.org
Cc: Octavian Purdila <octavian.purdila@intel.com>
Subject: [net-next v2 12/13] tcp: add queue_add_hash to tcp_request_sock_ops
Date: Wed, 25 Jun 2014 17:10:01 +0300	[thread overview]
Message-ID: <1403705402-14388-13-git-send-email-octavian.purdila@intel.com> (raw)
In-Reply-To: <1403705402-14388-1-git-send-email-octavian.purdila@intel.com>

Add queue_add_hash member to tcp_request_sock_ops so that we can later
unify tcp_v4_conn_request and tcp_v6_conn_request.

Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
---
 include/net/tcp.h   | 2 ++
 net/ipv4/tcp_ipv4.c | 3 ++-
 net/ipv6/tcp_ipv6.c | 3 ++-
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/include/net/tcp.h b/include/net/tcp.h
index 30fe98b..cec6e2c 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1615,6 +1615,8 @@ struct tcp_request_sock_ops {
 	int (*send_synack)(struct sock *sk, struct dst_entry *dst,
 			   struct flowi *fl, struct request_sock *req,
 			   u16 queue_mapping, struct tcp_fastopen_cookie *foc);
+	void (*queue_hash_add)(struct sock *sk, struct request_sock *req,
+			       const unsigned long timeout);
 };
 
 #ifdef CONFIG_SYN_COOKIES
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 499d440..845c39d 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1277,6 +1277,7 @@ static const struct tcp_request_sock_ops tcp_request_sock_ipv4_ops = {
 	.route_req	=	tcp_v4_route_req,
 	.init_seq	=	tcp_v4_init_sequence,
 	.send_synack	=	tcp_v4_send_synack,
+	.queue_hash_add =	inet_csk_reqsk_queue_hash_add,
 };
 
 int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
@@ -1403,7 +1404,7 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
 			goto drop_and_free;
 
 		tcp_rsk(req)->listener = NULL;
-		inet_csk_reqsk_queue_hash_add(sk, req, TCP_TIMEOUT_INIT);
+		af_ops->queue_hash_add(sk, req, TCP_TIMEOUT_INIT);
 	}
 
 	return 0;
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index ad65833..8232bc7 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -767,6 +767,7 @@ static const struct tcp_request_sock_ops tcp_request_sock_ipv6_ops = {
 	.route_req	=	tcp_v6_route_req,
 	.init_seq	=	tcp_v6_init_sequence,
 	.send_synack	=	tcp_v6_send_synack,
+	.queue_hash_add =	inet6_csk_reqsk_queue_hash_add,
 };
 
 static void tcp_v6_send_response(struct sk_buff *skb, u32 seq, u32 ack, u32 win,
@@ -1126,7 +1127,7 @@ static int tcp_v6_conn_request(struct sock *sk, struct sk_buff *skb)
 			goto drop_and_free;
 
 		tcp_rsk(req)->listener = NULL;
-		inet6_csk_reqsk_queue_hash_add(sk, req, TCP_TIMEOUT_INIT);
+		af_ops->queue_hash_add(sk, req, TCP_TIMEOUT_INIT);
 	}
 	return 0;
 
-- 
1.8.3.2

  parent reply	other threads:[~2014-06-25 14:10 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 14:09 [net-next v2 00/13] remove code duplication in tcp_v[46]_conn_request Octavian Purdila
2014-06-25 14:09 ` [net-next v2 01/13] tcp: cookie_v4_init_sequence: skb should be const Octavian Purdila
2014-06-25 14:09 ` [net-next v2 02/13] tcp: tcp_v[46]_conn_request: fix snt_synack initialization Octavian Purdila
2014-06-28  2:16   ` Neal Cardwell
2014-06-28  2:24     ` Neal Cardwell
2014-06-30 11:50     ` Octavian Purdila
2014-06-30 19:11       ` Neal Cardwell
2014-06-30 21:00         ` Octavian Purdila
2014-07-01  2:24           ` Neal Cardwell
2014-06-25 14:09 ` [net-next v2 03/13] net: remove inet6_reqsk_alloc Octavian Purdila
2014-06-25 17:59   ` Cong Wang
2014-06-25 18:04     ` Octavian Purdila
2014-06-25 14:09 ` [net-next v2 04/13] tcp: add init_req method to tcp_request_sock_ops Octavian Purdila
2014-06-25 14:09 ` [net-next v2 05/13] tcp: add init_cookie_seq " Octavian Purdila
2014-06-25 14:09 ` [net-next v2 06/13] tcp: add route_req " Octavian Purdila
2014-06-25 14:09 ` [net-next v2 07/13] tcp: move around a few calls in tcp_v6_conn_request Octavian Purdila
2014-06-25 14:29   ` Paul Moore
2014-06-25 14:09 ` [net-next v2 08/13] tcp: add init_seq method to tcp_request_sock_ops Octavian Purdila
2014-06-25 14:09 ` [net-next v2 09/13] tcp: add send_synack " Octavian Purdila
2014-06-25 14:09 ` [net-next v2 10/13] tcp: unify tcp_v4_rtx_synack and tcp_v6_rtx_synack Octavian Purdila
2014-06-25 14:10 ` [net-next v2 11/13] tcp: add mss_clamp to tcp_request_sock_ops Octavian Purdila
2014-06-25 14:10 ` Octavian Purdila [this message]
2014-06-25 19:05   ` [net-next v2 12/13] tcp: add queue_add_hash " Cong Wang
2014-06-25 14:10 ` [net-next v2 13/13] tcp: add tcp_conn_request Octavian Purdila
2014-06-27 22:54 ` [net-next v2 00/13] remove code duplication in tcp_v[46]_conn_request David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403705402-14388-13-git-send-email-octavian.purdila@intel.com \
    --to=octavian.purdila@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).