From: Octavian Purdila <octavian.purdila@intel.com>
To: netdev@vger.kernel.org
Cc: Octavian Purdila <octavian.purdila@intel.com>
Subject: [net-next v2 08/13] tcp: add init_seq method to tcp_request_sock_ops
Date: Wed, 25 Jun 2014 17:09:57 +0300 [thread overview]
Message-ID: <1403705402-14388-9-git-send-email-octavian.purdila@intel.com> (raw)
In-Reply-To: <1403705402-14388-1-git-send-email-octavian.purdila@intel.com>
More work in preparation of unifying tcp_v4_conn_request and
tcp_v6_conn_request: indirect the init sequence calls via the
tcp_request_sock_ops.
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
---
include/net/tcp.h | 1 +
net/ipv4/tcp_ipv4.c | 5 +++--
net/ipv6/tcp_ipv6.c | 3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 59fcc59..8cacf0d 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1608,6 +1608,7 @@ struct tcp_request_sock_ops {
struct dst_entry *(*route_req)(struct sock *sk, struct flowi *fl,
const struct request_sock *req,
bool *strict);
+ __u32 (*init_seq)(const struct sk_buff *skb);
};
#ifdef CONFIG_SYN_COOKIES
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 54fbbd8..4347826 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -99,7 +99,7 @@ static int tcp_v4_md5_hash_hdr(char *md5_hash, const struct tcp_md5sig_key *key,
struct inet_hashinfo tcp_hashinfo;
EXPORT_SYMBOL(tcp_hashinfo);
-static inline __u32 tcp_v4_init_sequence(const struct sk_buff *skb)
+static __u32 tcp_v4_init_sequence(const struct sk_buff *skb)
{
return secure_tcp_sequence_number(ip_hdr(skb)->daddr,
ip_hdr(skb)->saddr,
@@ -1284,6 +1284,7 @@ static const struct tcp_request_sock_ops tcp_request_sock_ipv4_ops = {
.cookie_init_seq = cookie_v4_init_sequence,
#endif
.route_req = tcp_v4_route_req,
+ .init_seq = tcp_v4_init_sequence,
};
int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
@@ -1391,7 +1392,7 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
goto drop_and_release;
}
- isn = tcp_v4_init_sequence(skb);
+ isn = af_ops->init_seq(skb);
}
if (!dst) {
dst = af_ops->route_req(sk, (struct flowi *)&fl4, req, NULL);
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 91b8a2e..2fd886f 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -775,6 +775,7 @@ static const struct tcp_request_sock_ops tcp_request_sock_ipv6_ops = {
.cookie_init_seq = cookie_v6_init_sequence,
#endif
.route_req = tcp_v6_route_req,
+ .init_seq = tcp_v6_init_sequence,
};
static void tcp_v6_send_response(struct sk_buff *skb, u32 seq, u32 ack, u32 win,
@@ -1114,7 +1115,7 @@ static int tcp_v6_conn_request(struct sock *sk, struct sk_buff *skb)
goto drop_and_release;
}
- isn = tcp_v6_init_sequence(skb);
+ isn = af_ops->init_seq(skb);
}
if (!dst) {
--
1.8.3.2
next prev parent reply other threads:[~2014-06-25 14:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 14:09 [net-next v2 00/13] remove code duplication in tcp_v[46]_conn_request Octavian Purdila
2014-06-25 14:09 ` [net-next v2 01/13] tcp: cookie_v4_init_sequence: skb should be const Octavian Purdila
2014-06-25 14:09 ` [net-next v2 02/13] tcp: tcp_v[46]_conn_request: fix snt_synack initialization Octavian Purdila
2014-06-28 2:16 ` Neal Cardwell
2014-06-28 2:24 ` Neal Cardwell
2014-06-30 11:50 ` Octavian Purdila
2014-06-30 19:11 ` Neal Cardwell
2014-06-30 21:00 ` Octavian Purdila
2014-07-01 2:24 ` Neal Cardwell
2014-06-25 14:09 ` [net-next v2 03/13] net: remove inet6_reqsk_alloc Octavian Purdila
2014-06-25 17:59 ` Cong Wang
2014-06-25 18:04 ` Octavian Purdila
2014-06-25 14:09 ` [net-next v2 04/13] tcp: add init_req method to tcp_request_sock_ops Octavian Purdila
2014-06-25 14:09 ` [net-next v2 05/13] tcp: add init_cookie_seq " Octavian Purdila
2014-06-25 14:09 ` [net-next v2 06/13] tcp: add route_req " Octavian Purdila
2014-06-25 14:09 ` [net-next v2 07/13] tcp: move around a few calls in tcp_v6_conn_request Octavian Purdila
2014-06-25 14:29 ` Paul Moore
2014-06-25 14:09 ` Octavian Purdila [this message]
2014-06-25 14:09 ` [net-next v2 09/13] tcp: add send_synack method to tcp_request_sock_ops Octavian Purdila
2014-06-25 14:09 ` [net-next v2 10/13] tcp: unify tcp_v4_rtx_synack and tcp_v6_rtx_synack Octavian Purdila
2014-06-25 14:10 ` [net-next v2 11/13] tcp: add mss_clamp to tcp_request_sock_ops Octavian Purdila
2014-06-25 14:10 ` [net-next v2 12/13] tcp: add queue_add_hash " Octavian Purdila
2014-06-25 19:05 ` Cong Wang
2014-06-25 14:10 ` [net-next v2 13/13] tcp: add tcp_conn_request Octavian Purdila
2014-06-27 22:54 ` [net-next v2 00/13] remove code duplication in tcp_v[46]_conn_request David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403705402-14388-9-git-send-email-octavian.purdila@intel.com \
--to=octavian.purdila@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).