From: roy.qing.li@gmail.com
To: netdev@vger.kernel.org
Cc: jim.epost@gmail.com, _govind@gmx.com
Subject: [PATCH] enic: fix a building failure
Date: Fri, 27 Jun 2014 10:09:39 +0800 [thread overview]
Message-ID: <1403834979-598-1-git-send-email-roy.qing.li@gmail.com> (raw)
In-Reply-To: <CA+r1ZhjoME0Okxi9kfFgOsMmieWwuhCX83DCKosKEM2NLAtAVA@mail.gmail.com>
From: Li RongQing <roy.qing.li@gmail.com>
When RFS_ACCEL is disabled, the building failed:
drivers/net/ethernet/cisco/enic/enic_main.c: In function ‘enic_open’:
drivers/net/ethernet/cisco/enic/enic_main.c:1603:2: error: implicit declaration
of function ‘enic_rfs_flw_tbl_init’ [-Werror=implicit-function-declaration]
enic_rfs_flw_tbl_init(enic);
^
drivers/net/ethernet/cisco/enic/enic_main.c: In function ‘enic_stop’:
drivers/net/ethernet/cisco/enic/enic_main.c:1630:2: error: implicit declaration
of function ‘enic_rfs_flw_tbl_free’ [-Werror=implicit-function-declaration]
enic_rfs_flw_tbl_free(enic);
In fact, these two functions have been defined separately for enabling RFS_ACCEL
and disabling RFS_ACCEL.
Reported-by: Jim Davis <jim.epost@gmail.com>
Cc: Govindarajulu Varadarajan <_govind@gmx.com>
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
drivers/net/ethernet/cisco/enic/enic_clsf.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/cisco/enic/enic_clsf.h b/drivers/net/ethernet/cisco/enic/enic_clsf.h
index 76a85bb..b38cc7e 100644
--- a/drivers/net/ethernet/cisco/enic/enic_clsf.h
+++ b/drivers/net/ethernet/cisco/enic/enic_clsf.h
@@ -9,11 +9,8 @@
int enic_addfltr_5t(struct enic *enic, struct flow_keys *keys, u16 rq);
int enic_delfltr(struct enic *enic, u16 filter_id);
-#ifdef CONFIG_RFS_ACCEL
void enic_rfs_flw_tbl_init(struct enic *enic);
void enic_rfs_flw_tbl_free(struct enic *enic);
int enic_rx_flow_steer(struct net_device *dev, const struct sk_buff *skb,
u16 rxq_index, u32 flow_id);
-#endif /* CONFIG_RFS_ACCEL */
-
#endif /* _ENIC_CLSF_H_ */
--
1.7.10.4
next prev parent reply other threads:[~2014-06-27 2:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 21:00 randconfig build error with next-20140624, in drivers/net/ethernet/cisco/enic/enic_main.c Jim Davis
2014-06-27 2:09 ` roy.qing.li [this message]
2014-06-27 2:20 ` [PATCH] enic: fix a building failure Li RongQing
2014-06-27 2:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403834979-598-1-git-send-email-roy.qing.li@gmail.com \
--to=roy.qing.li@gmail.com \
--cc=_govind@gmx.com \
--cc=jim.epost@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).