* [PATCH 1/1] drivers/net/hyperv/netvsc.c: remove unnecessary null test before kfree
@ 2014-06-28 18:44 Fabian Frederick
2014-07-03 1:22 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-28 18:44 UTC (permalink / raw)
To: haiyangz; +Cc: Fabian Frederick, netdev
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: netdev@vger.kernel.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/hyperv/netvsc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 4ed38ea..f13e0ac 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -1094,9 +1094,7 @@ close:
vmbus_close(device->channel);
cleanup:
-
- if (net_device)
- kfree(net_device);
+ kfree(net_device);
return ret;
}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drivers/net/hyperv/netvsc.c: remove unnecessary null test before kfree
2014-06-28 18:44 [PATCH 1/1] drivers/net/hyperv/netvsc.c: remove unnecessary null test before kfree Fabian Frederick
@ 2014-07-03 1:22 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-07-03 1:22 UTC (permalink / raw)
To: fabf; +Cc: haiyangz, netdev
From: Fabian Frederick <fabf@skynet.be>
Date: Sat, 28 Jun 2014 20:44:19 +0200
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-03 1:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-28 18:44 [PATCH 1/1] drivers/net/hyperv/netvsc.c: remove unnecessary null test before kfree Fabian Frederick
2014-07-03 1:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).