From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 08/14] i40e/i40evf: initialize context descriptor
Date: Tue, 1 Jul 2014 04:35:05 -0700 [thread overview]
Message-ID: <1404214511-26868-9-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1404214511-26868-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
Driver needs to initialize all members of context descriptor. Stale
data is possible otherwise.
Change-ID: Idc6b53af45583509da42d5ec0824cbaf78aee64f
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 1 +
drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index babb7e6..051e213 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -1991,6 +1991,7 @@ static void i40e_create_tx_ctx(struct i40e_ring *tx_ring,
/* cpu_to_le32 and assign to struct fields */
context_desc->tunneling_params = cpu_to_le32(cd_tunneling);
context_desc->l2tag2 = cpu_to_le16(cd_l2tag2);
+ context_desc->rsvd = cpu_to_le16(0);
context_desc->type_cmd_tso_mss = cpu_to_le64(cd_type_cmd_tso_mss);
}
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
index 48ebb6c..f2762f5 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
@@ -1336,6 +1336,7 @@ static void i40e_create_tx_ctx(struct i40e_ring *tx_ring,
/* cpu_to_le32 and assign to struct fields */
context_desc->tunneling_params = cpu_to_le32(cd_tunneling);
context_desc->l2tag2 = cpu_to_le16(cd_l2tag2);
+ context_desc->rsvd = cpu_to_le16(0);
context_desc->type_cmd_tso_mss = cpu_to_le64(cd_type_cmd_tso_mss);
}
--
1.9.3
next prev parent reply other threads:[~2014-07-01 11:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 11:34 [net-next 00/14][pull request] Intel Wired LAN Driver Updates 2014-07-01 Jeff Kirsher
2014-07-01 11:34 ` [net-next 01/14] i40e/i40evf: Add base address registers to aq struct Jeff Kirsher
2014-07-01 11:34 ` [net-next 02/14] i40e/i40evf: clear aq bah-bal on shutdown Jeff Kirsher
2014-07-01 11:35 ` [net-next 03/14] i40e: clear all queues and interrupts Jeff Kirsher
2014-07-01 11:35 ` [net-next 04/14] i40e: Correct mask assignment value Jeff Kirsher
2014-07-01 11:35 ` [net-next 05/14] i40evf: set flags before sending message Jeff Kirsher
2014-07-01 11:35 ` [net-next 06/14] i40e/i40evf: add ASQ write back timeout variable to AQ structure Jeff Kirsher
2014-07-01 11:35 ` [net-next 07/14] i40e: FD filter replay logic bug fix Jeff Kirsher
2014-07-01 11:35 ` Jeff Kirsher [this message]
2014-07-01 11:35 ` [net-next 09/14] i40e: limit GLLAN_TXPRE_QDIS to QINDX 0-127 Jeff Kirsher
2014-07-01 11:35 ` [net-next 10/14] i40e: remove linux/export.h header from i40e_ptp.c Jeff Kirsher
2014-07-01 11:35 ` [net-next 11/14] i40evf: change branding string Jeff Kirsher
2014-07-01 11:35 ` [net-next 12/14] i40e/i40evf: Bump i40e to 0.4.19 and i40evf to 0.9.38 Jeff Kirsher
2014-07-01 11:35 ` [net-next 13/14] igb: bring link up when PHY is powered up Jeff Kirsher
2014-07-01 11:35 ` [net-next 14/14] ixgbe: change PTP NSECS_PER_SEC to IXGBE_PTP_PPS_HALF_SECOND Jeff Kirsher
2014-07-02 6:09 ` [net-next 00/14][pull request] Intel Wired LAN Driver Updates 2014-07-01 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404214511-26868-9-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).