* [PATCH net-next] igb: do a reset on SR-IOV re-init if device is down
@ 2014-07-01 11:45 Stefan Assmann
2014-07-01 11:54 ` Jeff Kirsher
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Assmann @ 2014-07-01 11:45 UTC (permalink / raw)
To: netdev; +Cc: davem, e1000-devel, carolyn.wyborny, jeffrey.t.kirsher, sassmann
To properly re-initialize SR-IOV it is necessary to reset the device
even if it is already down. Not doing this may result in tx unit hangs.
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
---
drivers/net/ethernet/intel/igb/igb_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index f145adb..6f3cf45 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7578,6 +7578,8 @@ static int igb_sriov_reinit(struct pci_dev *dev)
if (netif_running(netdev))
igb_close(netdev);
+ else
+ igb_reset(adapter);
igb_clear_interrupt_scheme(adapter);
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] igb: do a reset on SR-IOV re-init if device is down
2014-07-01 11:45 [PATCH net-next] igb: do a reset on SR-IOV re-init if device is down Stefan Assmann
@ 2014-07-01 11:54 ` Jeff Kirsher
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Kirsher @ 2014-07-01 11:54 UTC (permalink / raw)
To: Stefan Assmann; +Cc: netdev, davem, e1000-devel, carolyn.wyborny
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
On Tue, 2014-07-01 at 13:45 +0200, Stefan Assmann wrote:
> To properly re-initialize SR-IOV it is necessary to reset the device
> even if it is already down. Not doing this may result in tx unit
> hangs.
>
> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 2 ++
> 1 file changed, 2 insertions(+)
Thanks Stefan, I have added your patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-01 11:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-01 11:45 [PATCH net-next] igb: do a reset on SR-IOV re-init if device is down Stefan Assmann
2014-07-01 11:54 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).