From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [Linux-zigbee-devel] [PATCH net-next v3] 6lowpan: mac802154: fix coding style issues Date: Tue, 01 Jul 2014 21:40:16 -0700 Message-ID: <1404276016.14624.57.camel@joe-AO725> References: <1404271869-2316-1-git-send-email-varkab@cdac.in> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Varka Bhadram , netdev , Varka Bhadram , David Miller , linux-zigbee-devel@lists.sourceforge.net To: Florian Fainelli Return-path: Received: from smtprelay0112.hostedemail.com ([216.40.44.112]:38198 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750917AbaGBEkU (ORCPT ); Wed, 2 Jul 2014 00:40:20 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2014-07-01 at 21:20 -0700, Florian Fainelli wrote: > Hi, > > 2014-07-01 20:31 GMT-07:00 Varka Bhadram : > > This patch fixed the coding style issues reported by checkpatch.pl > > > > following issues fixed: > > CHECK: Alignment should match open parenthesis > > It seems to me like checkpatch.pl should have a special case for > networking code and that specific condition because fixing things to > make checkpatch.pl happy seems not to agree with the general coding > style recommended and enforced in the networking code. In networking (net/ and drivers/net) alignment of multiline statements _should_ align to the open parenthesis and checkpatch already has a specific check for those directories. > I just saw that new warning added popping up on a bunch of drivers > that were properly fixed to match the networking coding style before > submission. Is there anything you want changed in checkpatch? If so, why? cheers, Joe