* [patch net-next] bonding: remove no longer relevant vlan warnings
@ 2014-07-02 9:55 Jiri Pirko
2014-07-02 12:03 ` Veaceslav Falico
2014-07-08 4:32 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Pirko @ 2014-07-02 9:55 UTC (permalink / raw)
To: netdev; +Cc: davem, j.vosburgh, vfalico, andy, teg, jay.vosburgh, mkubecek
These warnings are no longer relevant. Even when last slave is
removed, there is a valid address assigned to bond (random).
The correct functionality of vlans is ensured by maintaining unicast
list in vlan_sync_address().
Suggested-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
drivers/net/bonding/bond_main.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index ffefb70..09dc3ef 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1754,13 +1754,6 @@ static int __bond_release_one(struct net_device *bond_dev,
if (!bond_has_slaves(bond)) {
bond_set_carrier(bond);
eth_hw_addr_random(bond_dev);
-
- if (vlan_uses_dev(bond_dev)) {
- pr_warn("%s: Warning: clearing HW address of %s while it still has VLANs\n",
- bond_dev->name, bond_dev->name);
- pr_warn("%s: When re-adding slaves, make sure the bond's HW address matches its VLANs\n",
- bond_dev->name);
- }
}
unblock_netpoll_tx();
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch net-next] bonding: remove no longer relevant vlan warnings
2014-07-02 9:55 [patch net-next] bonding: remove no longer relevant vlan warnings Jiri Pirko
@ 2014-07-02 12:03 ` Veaceslav Falico
2014-07-08 4:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Veaceslav Falico @ 2014-07-02 12:03 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, davem, j.vosburgh, andy, teg, jay.vosburgh, mkubecek
On Wed, Jul 02, 2014 at 11:55:38AM +0200, Jiri Pirko wrote:
>These warnings are no longer relevant. Even when last slave is
>removed, there is a valid address assigned to bond (random).
>The correct functionality of vlans is ensured by maintaining unicast
>list in vlan_sync_address().
>
>Suggested-by: Jay Vosburgh <jay.vosburgh@canonical.com>
>Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Thanks for following up on this.
Acked-by: Veaceslav Falico <vfalico@gmail.com>
>---
> drivers/net/bonding/bond_main.c | 7 -------
> 1 file changed, 7 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index ffefb70..09dc3ef 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -1754,13 +1754,6 @@ static int __bond_release_one(struct net_device *bond_dev,
> if (!bond_has_slaves(bond)) {
> bond_set_carrier(bond);
> eth_hw_addr_random(bond_dev);
>-
>- if (vlan_uses_dev(bond_dev)) {
>- pr_warn("%s: Warning: clearing HW address of %s while it still has VLANs\n",
>- bond_dev->name, bond_dev->name);
>- pr_warn("%s: When re-adding slaves, make sure the bond's HW address matches its VLANs\n",
>- bond_dev->name);
>- }
> }
>
> unblock_netpoll_tx();
>--
>1.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch net-next] bonding: remove no longer relevant vlan warnings
2014-07-02 9:55 [patch net-next] bonding: remove no longer relevant vlan warnings Jiri Pirko
2014-07-02 12:03 ` Veaceslav Falico
@ 2014-07-08 4:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-07-08 4:32 UTC (permalink / raw)
To: jiri; +Cc: netdev, j.vosburgh, vfalico, andy, teg, jay.vosburgh, mkubecek
From: Jiri Pirko <jiri@resnulli.us>
Date: Wed, 2 Jul 2014 11:55:38 +0200
> These warnings are no longer relevant. Even when last slave is
> removed, there is a valid address assigned to bond (random).
> The correct functionality of vlans is ensured by maintaining unicast
> list in vlan_sync_address().
>
> Suggested-by: Jay Vosburgh <jay.vosburgh@canonical.com>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-08 4:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-02 9:55 [patch net-next] bonding: remove no longer relevant vlan warnings Jiri Pirko
2014-07-02 12:03 ` Veaceslav Falico
2014-07-08 4:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).