From: Joe Perches <joe@perches.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH v2] declance: Fix 64-bit compilation warnings
Date: Wed, 02 Jul 2014 22:16:05 -0700 [thread overview]
Message-ID: <1404364565.14741.26.camel@joe-AO725> (raw)
In-Reply-To: <alpine.LFD.2.11.1407030423300.15455@eddie.linux-mips.org>
On Thu, 2014-07-03 at 05:51 +0100, Maciej W. Rozycki wrote:
> > The kernel vsprintf implementation doesn't prefix
> > pointers with 0x, so you can use 0x%p if you really
> > want that with a leading prefix, but you don't have
> > to use it.
>
> It does, when the `#' format modifier is used (go try yourself!).
I know it does, but it's incidental.
I phrased it badly though.
There's no code that uses it.
$ git grep "%#p" | wc -l
0
And I know that code pretty well thanks.
> I think using 0x%p
> would be ugly; here it wouldn't really matter, but ordinarily allowing a
> format to produce `0x (null)' would be rather lame, so I don't want to
> spread examples someone might foolishly copy.
$ git grep "0x%p" | wc -l
1747
<shrug> What's one more...
cheers, Joe
next prev parent reply other threads:[~2014-07-03 5:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 2:10 [PATCH v2] declance: Fix 64-bit compilation warnings Maciej W. Rozycki
2014-07-03 1:28 ` David Miller
2014-07-03 2:29 ` Maciej W. Rozycki
2014-07-03 2:34 ` Maciej W. Rozycki
2014-07-03 3:05 ` Joe Perches
2014-07-03 4:51 ` Maciej W. Rozycki
2014-07-03 5:16 ` Joe Perches [this message]
2014-07-03 6:01 ` Maciej W. Rozycki
2014-07-03 6:25 ` Joe Perches
2014-07-03 16:57 ` Grant Likely
2014-07-05 14:56 ` Maciej W. Rozycki
2014-07-05 16:07 ` Joe Perches
2014-07-05 17:39 ` Maciej W. Rozycki
2014-07-05 18:08 ` Joe Perches
2014-07-05 18:20 ` Maciej W. Rozycki
2014-07-05 18:31 ` Joe Perches
2014-07-05 20:25 ` Maciej W. Rozycki
2014-07-05 20:45 ` [PATCH] vsprintf: Remove SPECIAL from pointer types Joe Perches
2014-07-06 11:44 ` Maciej W. Rozycki
2014-07-06 14:32 ` Joe Perches
2014-07-07 8:26 ` David Laight
2014-07-07 13:26 ` Joe Perches
2014-07-07 12:01 ` [PATCH v2] declance: Fix 64-bit compilation warnings Grant Likely
2014-07-07 12:18 ` Maciej W. Rozycki
2014-07-07 13:40 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404364565.14741.26.camel@joe-AO725 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox