From: varkabhadram@gmail.com
To: netdev@vger.kernel.org
Cc: mugunthanvnm@ti.com, linux@rainbow-software.org, balbi@ti.com,
george.cherian@ti.com, davem@davemloft.net,
Varka Bhadram <varkab@cdac.in>
Subject: [PATCH net 5/7] net: cpmac: fix missing a blank line after declarations
Date: Thu, 10 Jul 2014 10:17:58 +0530 [thread overview]
Message-ID: <1404967680-13206-6-git-send-email-varkabhadram@gmail.com> (raw)
In-Reply-To: <1404967680-13206-1-git-send-email-varkabhadram@gmail.com>
From: Varka Bhadram <varkab@cdac.in>
This patch insert a blank line after declaration
Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
drivers/net/ethernet/ti/cpmac.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
index 1520c19..3d3ead4 100644
--- a/drivers/net/ethernet/ti/cpmac.c
+++ b/drivers/net/ethernet/ti/cpmac.c
@@ -224,6 +224,7 @@ static void cpmac_dump_regs(struct net_device *dev)
{
int i;
struct cpmac_priv *priv = netdev_priv(dev);
+
for (i = 0; i < CPMAC_REG_END; i += 4) {
if (i % 16 == 0) {
if (i)
@@ -238,6 +239,7 @@ static void cpmac_dump_regs(struct net_device *dev)
static void cpmac_dump_desc(struct net_device *dev, struct cpmac_desc *desc)
{
int i;
+
netdev_dbg(dev, "desc[%p]:", desc);
for (i = 0; i < sizeof(*desc) / 4; i++)
pr_debug(" %08x", ((u32 *)desc)[i]);
@@ -248,6 +250,7 @@ static void cpmac_dump_all_desc(struct net_device *dev)
{
struct cpmac_priv *priv = netdev_priv(dev);
struct cpmac_desc *dump = priv->rx_head;
+
do {
cpmac_dump_desc(dev, dump);
dump = dump->next;
@@ -257,6 +260,7 @@ static void cpmac_dump_all_desc(struct net_device *dev)
static void cpmac_dump_skb(struct net_device *dev, struct sk_buff *skb)
{
int i;
+
netdev_dbg(dev, "skb 0x%p, len=%d\n", skb, skb->len);
for (i = 0; i < skb->len; i++) {
if (i % 16 == 0) {
@@ -681,6 +685,7 @@ static void cpmac_clear_rx(struct net_device *dev)
struct cpmac_priv *priv = netdev_priv(dev);
struct cpmac_desc *desc;
int i;
+
if (unlikely(!priv->rx_head))
return;
desc = priv->rx_head;
@@ -703,6 +708,7 @@ static void cpmac_clear_tx(struct net_device *dev)
{
struct cpmac_priv *priv = netdev_priv(dev);
int i;
+
if (unlikely(!priv->desc_ring))
return;
for (i = 0; i < CPMAC_QUEUES; i++) {
@@ -821,6 +827,7 @@ static void cpmac_tx_timeout(struct net_device *dev)
static int cpmac_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
{
struct cpmac_priv *priv = netdev_priv(dev);
+
if (!(netif_running(dev)))
return -EINVAL;
if (!priv->phy)
@@ -1181,6 +1188,7 @@ fail:
static int cpmac_remove(struct platform_device *pdev)
{
struct net_device *dev = platform_get_drvdata(pdev);
+
unregister_netdev(dev);
free_netdev(dev);
return 0;
--
1.7.9.5
next prev parent reply other threads:[~2014-07-10 4:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 4:47 [PATCH net 0/7] cleanup for AR7 CPMAC Ethernet controller driver varkabhadram
2014-07-10 4:47 ` [PATCH net 1/7] net: cpmac: remove space in macro defination varkabhadram
2014-07-10 15:30 ` Florian Fainelli
2014-07-10 15:38 ` Joe Perches
2014-07-10 4:47 ` [PATCH net 2/7] net: cpmac: fix comments varkabhadram
2014-07-10 4:47 ` [PATCH net 3/7] net: cpmac: dynamic debug fixes varkabhadram
2014-07-10 4:47 ` [PATCH net 4/7] net: cpmac: fix cpmac driver structure varkabhadram
2014-07-10 4:47 ` varkabhadram [this message]
2014-07-10 4:47 ` [PATCH net 6/7] net: cpmac: fix proper spacing before return statement varkabhadram
2014-07-10 4:48 ` [PATCH net 7/7] net: cpamc: fix in releasing resources varkabhadram
2014-07-10 5:27 ` [PATCH net 0/7] cleanup for AR7 CPMAC Ethernet controller driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404967680-13206-6-git-send-email-varkabhadram@gmail.com \
--to=varkabhadram@gmail.com \
--cc=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=george.cherian@ti.com \
--cc=linux@rainbow-software.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=varkab@cdac.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).