netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: varkabhadram@gmail.com
Cc: netdev@vger.kernel.org, mugunthanvnm@ti.com,
	linux@rainbow-software.org, balbi@ti.com, george.cherian@ti.com,
	davem@davemloft.net, Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH net v2 3/7] net: cpmac: dynamic debug fixes
Date: Thu, 10 Jul 2014 01:31:49 -0700	[thread overview]
Message-ID: <1404981109.8839.6.camel@joe-AO725> (raw)
In-Reply-To: <1404970545-26508-4-git-send-email-varkabhadram@gmail.com>

On Thu, 2014-07-10 at 11:05 +0530, varkabhadram@gmail.com wrote:
> From: Varka Bhadram <varkab@cdac.in>
> 
> This patch does the following changes
> 1. convert printk(KERN_DEBUG.. to netdev_dbg() if we have net_device object
>    or convert to dev_dbg() if we have device object.
[]
> diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
[]
> @@ -228,21 +228,20 @@ static void cpmac_dump_regs(struct net_device *dev)
>  		if (i % 16 == 0) {
>  			if (i)
>  				pr_cont("\n");
> -			printk(KERN_DEBUG "%s: reg[%p]:", dev->name,
> -			       priv->regs + i);
> +			netdev_dbg(dev, "reg[%p]:", priv->regs + i);
>  		}
> -		printk(" %08x", cpmac_read(priv->regs, i));
> +		pr_debug(" %08x", cpmac_read(priv->regs, i));
>  	}
> -	printk("\n");
> +	pr_debug("\n");
>  }

This changes output from a compact form to
usig very many individual lines like:

<7>dev->name: reg[addr]: p1 p2 p3 p4 p5 p6 p7 p8
<7>dev->name: reg[addr]: p9 pa ...            pn

to:

<7>bus desc/dev->name: reg[addr]:
<7> p1
<7> p2
...
<7>bus desc/dev->name: reg[addr]:
<7> p9
<7> pa
...
<7> pn

  reply	other threads:[~2014-07-10  8:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10  5:35 [PATCH net v2 0/7] cleanup for AR7 CPMAC Ethernet controller driver varkabhadram
2014-07-10  5:35 ` [PATCH net v2 1/7] net: cpmac: remove space in macro defination varkabhadram
2014-07-10 13:07   ` Felipe Balbi
2014-07-10  5:35 ` [PATCH net v2 2/7] net: cpmac: fix comments varkabhadram
2014-07-10 13:07   ` Felipe Balbi
2014-07-10  5:35 ` [PATCH net v2 3/7] net: cpmac: dynamic debug fixes varkabhadram
2014-07-10  8:31   ` Joe Perches [this message]
2014-07-10  8:45     ` Varka Bhadram
2014-07-10  9:03       ` Joe Perches
2014-07-10  9:35         ` Varka Bhadram
2014-07-10 10:10           ` Joe Perches
2014-07-10 10:11             ` Varka Bhadram
2014-07-10 10:17               ` Joe Perches
2014-07-10 13:08   ` Felipe Balbi
2014-07-10  5:35 ` [PATCH net v2 4/7] net: cpmac: fix cpmac driver structure varkabhadram
2014-07-10 13:08   ` Felipe Balbi
2014-07-10  5:35 ` [PATCH net v2 5/7] net: cpmac: fix missing a blank line after declarations varkabhadram
2014-07-10 13:08   ` Felipe Balbi
2014-07-10  5:35 ` [PATCH net v2 6/7] net: cpmac: fix proper spacing before return statement varkabhadram
2014-07-10 13:09   ` Felipe Balbi
2014-07-10  5:35 ` [PATCH net v2 7/7] net: cpmac: fix in releasing resources varkabhadram
2014-07-10 13:11   ` Felipe Balbi
2014-07-10  7:41 ` [PATCH net v2 0/7] cleanup for AR7 CPMAC Ethernet controller driver David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404981109.8839.6.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=balbi@ti.com \
    --cc=davem@davemloft.net \
    --cc=george.cherian@ti.com \
    --cc=linux@rainbow-software.org \
    --cc=mugunthanvnm@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=varkab@cdac.in \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).