* [net] igb: do a reset on SR-IOV re-init if device is down
@ 2014-07-10 10:29 Jeff Kirsher
2014-07-10 19:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2014-07-10 10:29 UTC (permalink / raw)
To: davem; +Cc: Stefan Assmann, netdev, nhorman, sassmann, stable, Jeff Kirsher
From: Stefan Assmann <sassmann@kpanic.de>
To properly re-initialize SR-IOV it is necessary to reset the device
even if it is already down. Not doing this may result in Tx unit hangs.
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 57a96e0..a9537ba 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7592,6 +7592,8 @@ static int igb_sriov_reinit(struct pci_dev *dev)
if (netif_running(netdev))
igb_close(netdev);
+ else
+ igb_reset(adapter);
igb_clear_interrupt_scheme(adapter);
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net] igb: do a reset on SR-IOV re-init if device is down
2014-07-10 10:29 [net] igb: do a reset on SR-IOV re-init if device is down Jeff Kirsher
@ 2014-07-10 19:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-07-10 19:45 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: sassmann, netdev, nhorman, sassmann, stable
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 10 Jul 2014 03:29:39 -0700
> From: Stefan Assmann <sassmann@kpanic.de>
>
> To properly re-initialize SR-IOV it is necessary to reset the device
> even if it is already down. Not doing this may result in Tx unit hangs.
>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
> Tested-by: Aaron Brown <aaron.f.brown@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks Jeff.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-10 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-10 10:29 [net] igb: do a reset on SR-IOV re-init if device is down Jeff Kirsher
2014-07-10 19:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).