From: Joe Perches <joe@perches.com>
To: Florian Fainelli <florian@openwrt.org>,
Varka Bhadram <varkabhadram@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
mugunthanvnm <mugunthanvnm@ti.com>,
Ondrej Zary <linux@rainbow-software.org>,
balbi@ti.com, george.cherian@ti.com,
David Miller <davem@davemloft.net>,
Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH net 1/7] net: cpmac: remove space in macro defination
Date: Thu, 10 Jul 2014 08:38:15 -0700 [thread overview]
Message-ID: <1405006695.2796.3.camel@joe-AO725> (raw)
In-Reply-To: <CAGVrzcY7OpzGwY8eO-iJ9u6H91r8ywUu7y0doP5G_1pyzBd0Wg@mail.gmail.com>
> 2014-07-09 21:47 GMT-07:00 <varkabhadram@gmail.com>:
[]
> > diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
> > index 7399a52..61eb691 100644
> > --- a/drivers/net/ethernet/ti/cpmac.c
> > +++ b/drivers/net/ethernet/ti/cpmac.c
> > @@ -67,42 +67,42 @@ MODULE_PARM_DESC(dumb_switch, "Assume switch is not connected to MDIO bus");
> > #define CPMAC_RX_CONTROL 0x0014
> > #define CPMAC_RX_TEARDOWN 0x0018
> > #define CPMAC_MBP 0x0100
> > -# define MBP_RXPASSCRC 0x40000000
> > -# define MBP_RXQOS 0x20000000
> > -# define MBP_RXNOCHAIN 0x10000000
> > -# define MBP_RXCMF 0x01000000
> > -# define MBP_RXSHORT 0x00800000
> > -# define MBP_RXCEF 0x00400000
> > -# define MBP_RXPROMISC 0x00200000
> > -# define MBP_PROMISCCHAN(channel) (((channel) & 0x7) << 16)
> > -# define MBP_RXBCAST 0x00002000
> > -# define MBP_BCASTCHAN(channel) (((channel) & 0x7) << 8)
> > -# define MBP_RXMCAST 0x00000020
> > -# define MBP_MCASTCHAN(channel) ((channel) & 0x7)
I think these are al relatively poor cleanups as
it is now no longer visually obvious that these
MBP_<FOO> defines are related to CPMAC_MBP
If you really want to do this I suggest something like:
#define CPMAC_MBP 0x0100
#define MBP_RXPASSCRC 0x40000000
next prev parent reply other threads:[~2014-07-10 15:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 4:47 [PATCH net 0/7] cleanup for AR7 CPMAC Ethernet controller driver varkabhadram
2014-07-10 4:47 ` [PATCH net 1/7] net: cpmac: remove space in macro defination varkabhadram
2014-07-10 15:30 ` Florian Fainelli
2014-07-10 15:38 ` Joe Perches [this message]
2014-07-10 4:47 ` [PATCH net 2/7] net: cpmac: fix comments varkabhadram
2014-07-10 4:47 ` [PATCH net 3/7] net: cpmac: dynamic debug fixes varkabhadram
2014-07-10 4:47 ` [PATCH net 4/7] net: cpmac: fix cpmac driver structure varkabhadram
2014-07-10 4:47 ` [PATCH net 5/7] net: cpmac: fix missing a blank line after declarations varkabhadram
2014-07-10 4:47 ` [PATCH net 6/7] net: cpmac: fix proper spacing before return statement varkabhadram
2014-07-10 4:48 ` [PATCH net 7/7] net: cpamc: fix in releasing resources varkabhadram
2014-07-10 5:27 ` [PATCH net 0/7] cleanup for AR7 CPMAC Ethernet controller driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405006695.2796.3.camel@joe-AO725 \
--to=joe@perches.com \
--cc=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=george.cherian@ti.com \
--cc=linux@rainbow-software.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=varkab@cdac.in \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).