From: Joe Perches <joe@perches.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Jason Baron <jbaron@akamai.com>
Cc: varkabhadram@gmail.com, netdev@vger.kernel.org,
mugunthanvnm@ti.com, linux@rainbow-software.org, balbi@ti.com,
george.cherian@ti.com, davem@davemloft.net,
Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH net-next] net: cpmac: fix in debug messages
Date: Thu, 10 Jul 2014 11:18:57 -0700 [thread overview]
Message-ID: <1405016337.2796.6.camel@joe-AO725> (raw)
In-Reply-To: <53BECE0E.3030209@cogentembedded.com>
On Thu, 2014-07-10 at 21:31 +0400, Sergei Shtylyov wrote:
> > When we use pr_debug()/netdev_dbg() new lines are inserting in b/w
> > the values. The format when i use the printk()
>
> Please use pr_cont() instead.
Using pr_cont to continue a <foo>_dbg statement is
ineffective.
There really should be a <foo>_dbg_cont mechanism,
but neither normal pr_debug nor dynamic debug support
such a thing.
next prev parent reply other threads:[~2014-07-10 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 9:59 [PATCH net-next] net: cpmac: fix in debug messages varkabhadram
2014-07-10 10:04 ` David Laight
2014-07-10 17:31 ` Sergei Shtylyov
2014-07-10 18:18 ` Joe Perches [this message]
2014-07-10 23:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405016337.2796.6.camel@joe-AO725 \
--to=joe@perches.com \
--cc=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=george.cherian@ti.com \
--cc=jbaron@akamai.com \
--cc=linux@rainbow-software.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=varkab@cdac.in \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).