* [PATCH net] net: bcmgenet: fix RGMII_MODE_EN bit
@ 2014-07-11 23:55 Florian Fainelli
2014-07-14 5:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2014-07-11 23:55 UTC (permalink / raw)
To: netdev; +Cc: davem, Florian Fainelli
RGMII_MODE_EN bit was defined to 0, while it is actually 6. It was not
much of a problem on older designs where this was a no-op, and the RGMII
data-path would always be enabled, but newer GENET controllers need to
explicitely enable their RGMII data-pad using this bit.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.h b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
index 0f117105fed1..e23c993b1362 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.h
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
@@ -331,9 +331,9 @@ struct bcmgenet_mib_counters {
#define EXT_ENERGY_DET_MASK (1 << 12)
#define EXT_RGMII_OOB_CTRL 0x0C
-#define RGMII_MODE_EN (1 << 0)
#define RGMII_LINK (1 << 4)
#define OOB_DISABLE (1 << 5)
+#define RGMII_MODE_EN (1 << 6)
#define ID_MODE_DIS (1 << 16)
#define EXT_GPHY_CTRL 0x1C
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: bcmgenet: fix RGMII_MODE_EN bit
2014-07-11 23:55 [PATCH net] net: bcmgenet: fix RGMII_MODE_EN bit Florian Fainelli
@ 2014-07-14 5:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-07-14 5:55 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri, 11 Jul 2014 16:55:15 -0700
> RGMII_MODE_EN bit was defined to 0, while it is actually 6. It was not
> much of a problem on older designs where this was a no-op, and the RGMII
> data-path would always be enabled, but newer GENET controllers need to
> explicitely enable their RGMII data-pad using this bit.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-14 5:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-11 23:55 [PATCH net] net: bcmgenet: fix RGMII_MODE_EN bit Florian Fainelli
2014-07-14 5:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).