Re: [PATCH 1/4] iw_cxgb4: Detect Ing. Padding Boundary at run-time

[Yann Droneaud <ydroneaud@opteya.com>]

Hi,

Le vendredi 11 juillet 2014 à 20:44 +0530, Hariprasad Shenai a écrit :
> Updates iw_cxgb4 to determine the Ingress Padding Boundary from
> cxgb4_lld_info, and take subsequent actions.
> 
> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
> ---
>  drivers/infiniband/hw/cxgb4/cq.c                |    4 ++--
>  drivers/infiniband/hw/cxgb4/device.c            |   21 +++++++++++++++++++++
>  drivers/infiniband/hw/cxgb4/iw_cxgb4.h          |   12 ++++++++++++
>  drivers/infiniband/hw/cxgb4/provider.c          |    4 ++--
>  drivers/infiniband/hw/cxgb4/qp.c                |   10 ++++++----
>  drivers/infiniband/hw/cxgb4/t4.h                |    8 --------
>  drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |    2 ++
>  drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h  |    2 ++
>  8 files changed, 47 insertions(+), 16 deletions(-)
> 

[...]

> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index dd93aad..95e6c6c 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -768,6 +768,27 @@ static struct c4iw_dev *c4iw_alloc(const struct cxgb4_lld_info *infop)
>  	}
>  	devp->rdev.lldi = *infop;
>  
> +	/* init various hw-queue params based on lld info */
> +	pr_info("%s: ing. padding boundary is %d, egrsstatuspagesize = %d\n",
> +		__func__, devp->rdev.lldi.sge_ingpadboundary,
> +		devp->rdev.lldi.sge_egrstatuspagesize);

Is this really needed ?

Use dev_info() or perhaps dev_dbg() instead of pr_info().

Regards.

-- 
Yann Droneaud
OPTEYA