From: Johannes Berg <johannes@sipsolutions.net>
To: Tom Gundersen <teg@jklm.no>
Cc: netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH net-next v9 2/9] net: nl80211 - make rdev_add_virtual_intf take name_assign_type
Date: Thu, 17 Jul 2014 11:23:06 +0200 [thread overview]
Message-ID: <1405588986.20120.1.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAG-2HqWGVqNFJGeh_Uj2pbC-+m8tsHeeO=f_3MD8JMcTDvpDDw@mail.gmail.com> (sfid-20140717_111719_497030_C610CFFC)
On Thu, 2014-07-17 at 11:16 +0200, Tom Gundersen wrote:
> >> static struct wireless_dev *ath6kl_cfg80211_add_iface(struct wiphy *wiphy,
> >> const char *name,
> >> + unsigned char name_assign_type,
> >
> > unsigned char for an enum is really odd.
>
> Hm, this was based on the addr_assign_type attribute, which also is an
> unsigned char (and serves a very similar purpose).
>
> Out of interest, what would you have preferred (and why)?
Even if it eventually ends up being assigned to a u8 or something, it
seems passing it around as an enum makes the interfaces better?
johannes
next prev parent reply other threads:[~2014-07-17 9:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 8:06 [PATCH net-next v9 0/9] net: set the correct name_assign_type for more devices Tom Gundersen
2014-07-17 8:06 ` [PATCH net-next v9 1/9] net: set name assign type for names assigned using a static string Tom Gundersen
2014-07-17 8:06 ` [PATCH net-next v9 2/9] net: nl80211 - make rdev_add_virtual_intf take name_assign_type Tom Gundersen
2014-07-17 9:04 ` Johannes Berg
2014-07-17 9:16 ` Tom Gundersen
2014-07-17 9:23 ` Johannes Berg [this message]
2014-07-17 8:06 ` [PATCH net-next v9 3/9] net: nl802154 - make add_iface take name assign type Tom Gundersen
[not found] ` <1405584370-30054-4-git-send-email-teg-B22kvLQNl6c@public.gmane.org>
2014-07-17 23:19 ` David Miller
[not found] ` <20140717.161931.283488873926282207.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-07-18 8:18 ` Alexander Aring
2014-07-18 8:29 ` David Laight
2014-07-18 8:41 ` Tom Gundersen
2014-07-17 8:06 ` [PATCH net-next v9 4/9] net: set name_assign_type when setting names via ioctls Tom Gundersen
2014-07-17 23:20 ` David Miller
2014-07-18 8:59 ` Tom Gundersen
2014-07-17 8:06 ` [PATCH net-next v9 5/9] net: bond - make bond_create take name_assign_type Tom Gundersen
2014-07-17 8:06 ` [PATCH net-next v9 6/9] net: isdn - set name assign type Tom Gundersen
2014-07-17 8:06 ` [PATCH net-next v9 7/9] net: vlan " Tom Gundersen
2014-07-17 8:06 ` [PATCH net-next v9 8/9] net: openvswitch " Tom Gundersen
[not found] ` <1405584370-30054-9-git-send-email-teg-B22kvLQNl6c@public.gmane.org>
2014-07-17 18:22 ` Pravin Shelar
2014-07-17 8:06 ` [PATCH net-next v9 9/9] net: ppp " Tom Gundersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405588986.20120.1.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=teg@jklm.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).