From: Joe Perches <joe@perches.com>
To: Veaceslav Falico <vfalico@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Tom Gundersen <teg@jklm.no>
Subject: Re: [PATCH v2 net-next 1/2] net: use dev->name in netdev_pr* when it's available
Date: Thu, 17 Jul 2014 09:58:16 -0700 [thread overview]
Message-ID: <1405616296.12363.45.camel@joe-AO725> (raw)
In-Reply-To: <20140717163812.GA20406@mikrodark.usersys.redhat.com>
On Thu, 2014-07-17 at 18:38 +0200, Veaceslav Falico wrote:
> On Thu, Jul 17, 2014 at 09:36:08AM -0700, Joe Perches wrote:
> >On Thu, 2014-07-17 at 18:25 +0200, Veaceslav Falico wrote:
> >> On Thu, Jul 17, 2014 at 09:18:44AM -0700, Joe Perches wrote:
> >> >On Thu, 2014-07-17 at 16:09 +0200, Veaceslav Falico wrote:
> >> >> netdev_name() returns dev->name only when the net_device is in
> >> >> NETREG_REGISTERED state.
> >[]
> >> >Maybe this should not be inline and become something like:
> >>
> >> It will miss the states then, when it's not NETREG_REGISTERED.
> >
> >If it's registered, it has a valid name via
> >dev_get_valid_name() doesn't it?
>
> Yes, I'm speaking about the NETREG_* states when it's not registered.
>
> i.e.:
>
> Jul 17 13:35:29 darkmag kernel: [ 602.686489] bond2 (unregistering): Released all slaves
OK, I hadn't read the patch where netdev_reg_state was emitted.
Still, it's probably smaller overall code to uninline it now.
next prev parent reply other threads:[~2014-07-17 16:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 14:09 [PATCH v2 net-next 0/2] net: print net_device name/state more often Veaceslav Falico
2014-07-17 14:09 ` [PATCH v2 net-next 1/2] net: use dev->name in netdev_pr* when it's available Veaceslav Falico
2014-07-17 16:18 ` Joe Perches
2014-07-17 16:25 ` Veaceslav Falico
2014-07-17 16:36 ` Joe Perches
2014-07-17 16:38 ` Veaceslav Falico
2014-07-17 16:58 ` Joe Perches [this message]
2014-07-17 16:58 ` Veaceslav Falico
2014-07-17 14:09 ` [PATCH v2 net-next 2/2] net: print net_device reg_state in netdev_* unless it's registered Veaceslav Falico
2014-07-17 17:00 ` Joe Perches
2014-07-17 17:27 ` Veaceslav Falico
2014-07-17 14:48 ` [PATCH v2 net-next 0/2] net: print net_device name/state more often David Laight
2014-07-17 15:24 ` Veaceslav Falico
2014-07-17 15:25 ` Tom Gundersen
2014-07-17 15:27 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405616296.12363.45.camel@joe-AO725 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=teg@jklm.no \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).