netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Beniamino Galvani <b.galvani@gmail.com>
To: netdev@vger.kernel.org
Cc: "Alexey Brodkin" <Alexey.Brodkin@synopsys.com>,
	"Vineet Gupta" <Vineet.Gupta1@synopsys.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Max Schwarz" <max.schwarz@online.de>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Wei Yongjun" <yongjun_wei@trendmicro.com.cn>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <eric.dumazet@gmail.com>,
	linux-kernel@vger.kernel.org,
	"Beniamino Galvani" <b.galvani@gmail.com>
Subject: [RFC PATCH 0/2] net: arc_emac: fix tx issues
Date: Sun, 20 Jul 2014 17:44:56 +0200	[thread overview]
Message-ID: <1405871098-5663-1-git-send-email-b.galvani@gmail.com> (raw)

Hi,

I've found a strange behaviour of the ARC EMAC driver while doing some
tests on a Rockchip based Radxa Rock board and the following patches
are a try to solve the problem. I'm not sure if they are correct or if
there's a better way to do the same thing, so I'd like to receive some
feedback on this.

The problem I'm facing is that the transmission of a UDP stream from
the device stops immediately with the socket send buffer full and this
seems due to the current implementation of tx reclaiming.

With the two patches below, which do the following:

 - enable tx interrupts, which are used to trigger a napi poll and
   thus a clean of tx ring
 - fix a possible race between xmit and tx clean

everything seems to work properly.

Any comments are welcome,
Beniamino

Beniamino Galvani (2):
  net: arc_emac: enable tx interrupts
  net: arc_emac: prevent reuse of unreclaimed tx descriptors

 drivers/net/ethernet/arc/emac_main.c |   56 +++++++++++++++++++++++-----------
 1 file changed, 38 insertions(+), 18 deletions(-)

-- 
1.7.10.4

             reply	other threads:[~2014-07-20 15:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-20 15:44 Beniamino Galvani [this message]
2014-07-20 15:44 ` [RFC PATCH 1/2] net: arc_emac: enable tx interrupts Beniamino Galvani
2014-07-20 15:44 ` [RFC PATCH 2/2] net: arc_emac: prevent reuse of unreclaimed tx descriptors Beniamino Galvani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405871098-5663-1-git-send-email-b.galvani@gmail.com \
    --to=b.galvani@gmail.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.schwarz@online.de \
    --cc=netdev@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).