From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net-next v2 01/11] net: bcmgenet: remove wol_enabled conditional code
Date: Mon, 21 Jul 2014 15:29:19 -0700 [thread overview]
Message-ID: <1405981769-24618-2-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1405981769-24618-1-git-send-email-f.fainelli@gmail.com>
Checking for wol_enabled in bcmgenet_close() is bogus, since no other
code places set priv->wol_enabled. Remove that as it will conflict with
the upcoming and functional Wake-on-LAN implementation.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes in v2:
- remove one more call site which checked for wol_enabled
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 9 ---------
drivers/net/ethernet/broadcom/genet/bcmgenet.h | 1 -
2 files changed, 10 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 16281ad2da12..3cbf29095257 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -1994,12 +1994,6 @@ static int bcmgenet_open(struct net_device *dev)
bcmgenet_set_hw_addr(priv, dev->dev_addr);
- if (priv->wol_enabled) {
- ret = bcmgenet_wol_resume(priv);
- if (ret)
- return ret;
- }
-
if (phy_is_internal(priv->phydev)) {
reg = bcmgenet_ext_readl(priv, EXT_EXT_PWR_MGMT);
reg |= EXT_ENERGY_DET_MASK;
@@ -2161,9 +2155,6 @@ static int bcmgenet_close(struct net_device *dev)
if (phy_is_internal(priv->phydev))
bcmgenet_power_down(priv, GENET_POWER_PASSIVE);
- if (priv->wol_enabled)
- clk_enable(priv->clk_wol);
-
if (!IS_ERR(priv->clk))
clk_disable_unprepare(priv->clk);
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.h b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
index e23c993b1362..f4891a1b6758 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.h
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
@@ -583,7 +583,6 @@ struct bcmgenet_priv {
struct platform_device *pdev;
/* WOL */
- unsigned long wol_enabled;
struct clk *clk_wol;
u32 wolopts;
--
1.9.1
next prev parent reply other threads:[~2014-07-21 22:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 22:29 [PATCH net-next v2 00/11] net: bcmgenet: PM and Wake-on-LAN Florian Fainelli
2014-07-21 22:29 ` Florian Fainelli [this message]
2014-07-21 22:29 ` [PATCH net-next v2 02/11] net: bcmgenet: add umac_enable_set helper Florian Fainelli
2014-07-21 22:29 ` [PATCH net-next v2 03/11] net: bcmgenet: modularize bcmgenet_{open,close} Florian Fainelli
2014-07-21 22:29 ` [PATCH net-next v2 04/11] net: bcmgenet: add suspend/resume callbacks Florian Fainelli
2014-07-21 22:29 ` [PATCH net-next v2 05/11] net: bcmgenet: request Wake-on-LAN interrupt Florian Fainelli
2014-07-21 22:29 ` [PATCH net-next v2 06/11] net: bcmgenet: add Wake-on-LAN support code Florian Fainelli
2014-07-21 22:29 ` [PATCH net-next v2 07/11] net: bcmgenet: handle GENET_POWER_WOL_MAGIC Florian Fainelli
2014-07-21 22:29 ` [PATCH net-next v2 08/11] net: bcmgenet: handle UMAC_IRQ_MPD_R interrupt bit Florian Fainelli
2014-07-21 22:29 ` [PATCH net-next v2 09/11] net: bcmgenet: fix bcmgenet_wol_resume Florian Fainelli
2014-07-21 22:29 ` [PATCH net-next v2 10/11] net: bcmgenet: suspend and resume from Wake-on-LAN Florian Fainelli
2014-07-21 22:29 ` [PATCH net-next v2 11/11] net: bcmgenet: hook ethtool set/get_wol operations Florian Fainelli
2014-07-21 23:07 ` [PATCH net-next v2 00/11] net: bcmgenet: PM and Wake-on-LAN David Miller
2014-07-22 20:20 ` Francois Romieu
2014-07-22 20:29 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405981769-24618-2-git-send-email-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).