* [PATCH] atm: Remove fix me in solos-pci
@ 2014-07-22 4:07 Nicholas Krause
2014-07-22 11:43 ` chas williams - CONTRACTOR
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Krause @ 2014-07-22 4:07 UTC (permalink / raw)
To: chas; +Cc: linux-atm-general, netdev
This removes a fix me as the default statement for solos_bh is correct
and needs no fixing.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/atm/solos-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 943cf0d..58a0a8f 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -851,7 +851,7 @@ static void solos_bh(unsigned long card_arg)
break;
case PKT_COMMAND:
- default: /* FIXME: Not really, surely? */
+ default:
if (process_command(card, port, skb))
break;
spin_lock(&card->cli_queue_lock);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: Remove fix me in solos-pci
2014-07-22 4:07 [PATCH] atm: Remove fix me in solos-pci Nicholas Krause
@ 2014-07-22 11:43 ` chas williams - CONTRACTOR
2014-07-22 17:47 ` Nick Krause
0 siblings, 1 reply; 3+ messages in thread
From: chas williams - CONTRACTOR @ 2014-07-22 11:43 UTC (permalink / raw)
To: Nicholas Krause; +Cc: linux-atm-general, netdev
Guy Ellis of Transverse says that Nathan Williams,
nathan@traverse.com.au, will address this issue when he returns
from vacation. So let's just wait for the 'official' fix.
On Tue, 22 Jul 2014 00:07:20 -0400
Nicholas Krause <xerofoify@gmail.com> wrote:
> This removes a fix me as the default statement for solos_bh is correct
> and needs no fixing.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/atm/solos-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
> index 943cf0d..58a0a8f 100644
> --- a/drivers/atm/solos-pci.c
> +++ b/drivers/atm/solos-pci.c
> @@ -851,7 +851,7 @@ static void solos_bh(unsigned long card_arg)
> break;
>
> case PKT_COMMAND:
> - default: /* FIXME: Not really, surely? */
> + default:
> if (process_command(card, port, skb))
> break;
> spin_lock(&card->cli_queue_lock);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: Remove fix me in solos-pci
2014-07-22 11:43 ` chas williams - CONTRACTOR
@ 2014-07-22 17:47 ` Nick Krause
0 siblings, 0 replies; 3+ messages in thread
From: Nick Krause @ 2014-07-22 17:47 UTC (permalink / raw)
To: chas williams - CONTRACTOR; +Cc: linux-atm-general, netdev
On Tue, Jul 22, 2014 at 7:43 AM, chas williams - CONTRACTOR
<chas@cmf.nrl.navy.mil> wrote:
> Guy Ellis of Transverse says that Nathan Williams,
> nathan@traverse.com.au, will address this issue when he returns
> from vacation. So let's just wait for the 'official' fix.
>
> On Tue, 22 Jul 2014 00:07:20 -0400
> Nicholas Krause <xerofoify@gmail.com> wrote:
>
>> This removes a fix me as the default statement for solos_bh is correct
>> and needs no fixing.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>> drivers/atm/solos-pci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
>> index 943cf0d..58a0a8f 100644
>> --- a/drivers/atm/solos-pci.c
>> +++ b/drivers/atm/solos-pci.c
>> @@ -851,7 +851,7 @@ static void solos_bh(unsigned long card_arg)
>> break;
>>
>> case PKT_COMMAND:
>> - default: /* FIXME: Not really, surely? */
>> + default:
>> if (process_command(card, port, skb))
>> break;
>> spin_lock(&card->cli_queue_lock);
>
Very well then I just this is closed.
Cheers Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-22 17:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-22 4:07 [PATCH] atm: Remove fix me in solos-pci Nicholas Krause
2014-07-22 11:43 ` chas williams - CONTRACTOR
2014-07-22 17:47 ` Nick Krause
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).