From: Joe Perches <joe@perches.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next 2/6] net: bcmgenet: add missing blank line after declaration
Date: Tue, 22 Jul 2014 21:35:26 -0700 [thread overview]
Message-ID: <1406090126.2755.13.camel@joe-AO725> (raw)
In-Reply-To: <1406051718-15883-3-git-send-email-f.fainelli@gmail.com>
On Tue, 2014-07-22 at 10:55 -0700, Florian Fainelli wrote:
> checkpatch flagged a bunch of problems in bcmgenet.h with: WARNING:
> Missing a blank line after declarations, fix them.
[]
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.h b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
[]
> @@ -438,6 +438,7 @@ struct bcmgenet_mib_counters {
> struct enet_cb {
> struct sk_buff *skb;
> void __iomem *bd_addr;
> +
> DEFINE_DMA_UNMAP_ADDR(dma_addr);
> DEFINE_DMA_UNMAP_LEN(dma_len);
> };
> @@ -503,6 +504,7 @@ struct bcmgenet_tx_ring {
> unsigned int prod_index; /* Tx ring producer index SW copy */
> unsigned int cb_ptr; /* Tx ring initial CB ptr */
> unsigned int end_ptr; /* Tx ring end CB ptr */
> +
> void (*int_enable)(struct bcmgenet_priv *priv,
> struct bcmgenet_tx_ring *);
> void (*int_disable)(struct bcmgenet_priv *priv,
checkpatch false positives.
The first is a macro definition, the second is a function pointer.
Please use the version in -next.
next prev parent reply other threads:[~2014-07-23 4:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 17:55 [PATCH net-next 0/6] net: bcmgenet: checkpatch fixes Florian Fainelli
2014-07-22 17:55 ` [PATCH net-next 1/6] net: bcmgenet: remove FSF mail address Florian Fainelli
2014-07-22 17:55 ` [PATCH net-next 2/6] net: bcmgenet: add missing blank line after declaration Florian Fainelli
2014-07-23 4:35 ` Joe Perches [this message]
2014-07-22 17:55 ` [PATCH net-next 3/6] net: bcmgenet: re-align multiple lines correctly Florian Fainelli
2014-07-23 4:41 ` Joe Perches
2014-07-22 17:55 ` [PATCH net-next 4/6] net: bcmgenet: add and remove missing blank lines Florian Fainelli
2014-07-22 17:55 ` [PATCH net-next 5/6] net: bcmgenet: add missing braces to some if statements Florian Fainelli
2014-07-22 17:55 ` [PATCH net-next 6/6] net: bcmgenet: use kcalloc instead of kzalloc Florian Fainelli
2014-07-22 17:57 ` [PATCH net-next 0/6] net: bcmgenet: checkpatch fixes Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406090126.2755.13.camel@joe-AO725 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).