From: Joe Perches <joe@perches.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next 3/6] net: bcmgenet: re-align multiple lines correctly
Date: Tue, 22 Jul 2014 21:41:30 -0700 [thread overview]
Message-ID: <1406090490.2755.18.camel@joe-AO725> (raw)
In-Reply-To: <1406051718-15883-4-git-send-email-f.fainelli@gmail.com>
On Tue, 2014-07-22 at 10:55 -0700, Florian Fainelli wrote:
> checkpatch.pl flagged a lot of "CHECK: Alignment should match open
> parenthesis" checks, fix all of them to make the driver neater.
trivial notes
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
[]
> @@ -670,7 +668,7 @@ static void bcmgenet_update_mib_counters(struct bcmgenet_priv *priv)
> if (s->type != BCMGENET_STAT_MIB_RX)
> offset = BCMGENET_STAT_OFFSET;
> val = bcmgenet_umac_readl(priv, UMAC_MIB_START +
> - j + offset);
> + j + offset);
Maybe better as:
val = bcmgenet_umac_readl(priv,
UMAC_MIB_START + j + offset);
> @@ -1318,7 +1315,7 @@ static unsigned int bcmgenet_desc_rx(struct bcmgenet_priv *priv,
>
> if (unlikely(!(dma_flag & DMA_EOP) || !(dma_flag & DMA_SOP))) {
> netif_err(priv, rx_status, dev,
> - "Droping fragmented packet!\n");
> + "Droping fragmented packet!\n");
dropping
next prev parent reply other threads:[~2014-07-23 4:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 17:55 [PATCH net-next 0/6] net: bcmgenet: checkpatch fixes Florian Fainelli
2014-07-22 17:55 ` [PATCH net-next 1/6] net: bcmgenet: remove FSF mail address Florian Fainelli
2014-07-22 17:55 ` [PATCH net-next 2/6] net: bcmgenet: add missing blank line after declaration Florian Fainelli
2014-07-23 4:35 ` Joe Perches
2014-07-22 17:55 ` [PATCH net-next 3/6] net: bcmgenet: re-align multiple lines correctly Florian Fainelli
2014-07-23 4:41 ` Joe Perches [this message]
2014-07-22 17:55 ` [PATCH net-next 4/6] net: bcmgenet: add and remove missing blank lines Florian Fainelli
2014-07-22 17:55 ` [PATCH net-next 5/6] net: bcmgenet: add missing braces to some if statements Florian Fainelli
2014-07-22 17:55 ` [PATCH net-next 6/6] net: bcmgenet: use kcalloc instead of kzalloc Florian Fainelli
2014-07-22 17:57 ` [PATCH net-next 0/6] net: bcmgenet: checkpatch fixes Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406090490.2755.18.camel@joe-AO725 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox