From: Jun Zhao <mypopydev@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Cong Wang <cwang@twopensource.com>,
Pravin B Shelar <pshelar@nicira.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
stephen hemminger <stephen@networkplumber.org>,
Tom Herbert <therbert@google.com>,
netdev@vger.kernel.org, Francesco Fusco <ffusco@redhat.com>,
Veaceslav Falico <vfalico@redhat.com>,
Duan Jiong <duanj.fnst@cn.fujitsu.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Jiri Pirko <jiri@resnulli.us>,
David Stevens <dlstevens@us.ibm.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Daniel Borkmann <dborkman@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jun Zhao <mypopydev@gmail.com>
Subject: [PATCH 1/1] neighbour : fix ndm_type type error issue
Date: Sat, 26 Jul 2014 00:38:59 +0800 [thread overview]
Message-ID: <1406306339-16151-1-git-send-email-mypopydev@gmail.com> (raw)
ndm_type means L3 address type, in neighbour proxy and vxlan, it's RTN_UNICAST.
NDA_DST is for netlink TLV type, hence it's not right value in this context.
Signed-off-by: Jun Zhao <mypopydev@gmail.com>
---
drivers/net/vxlan.c | 2 +-
net/core/neighbour.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index d3f3e5d..1fb7b37 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -340,7 +340,7 @@ static int vxlan_fdb_info(struct sk_buff *skb, struct vxlan_dev *vxlan,
ndm->ndm_state = fdb->state;
ndm->ndm_ifindex = vxlan->dev->ifindex;
ndm->ndm_flags = fdb->flags;
- ndm->ndm_type = NDA_DST;
+ ndm->ndm_type = RTN_UNICAST;
if (send_eth && nla_put(skb, NDA_LLADDR, ETH_ALEN, &fdb->eth_addr))
goto nla_put_failure;
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 559890b..ef31fef 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -2249,7 +2249,7 @@ static int pneigh_fill_info(struct sk_buff *skb, struct pneigh_entry *pn,
ndm->ndm_pad1 = 0;
ndm->ndm_pad2 = 0;
ndm->ndm_flags = pn->flags | NTF_PROXY;
- ndm->ndm_type = NDA_DST;
+ ndm->ndm_type = RTN_UNICAST;
ndm->ndm_ifindex = pn->dev->ifindex;
ndm->ndm_state = NUD_NONE;
--
1.7.10.4
next reply other threads:[~2014-07-25 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 16:38 Jun Zhao [this message]
2014-07-25 23:21 ` [PATCH 1/1] neighbour : fix ndm_type type error issue Cong Wang
2014-07-25 23:24 ` Hannes Frederic Sowa
2014-07-26 0:29 ` Jun Zhao
2014-07-26 13:42 ` Hannes Frederic Sowa
2014-07-26 15:05 ` Jun Zhao
2014-07-29 0:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406306339-16151-1-git-send-email-mypopydev@gmail.com \
--to=mypopydev@gmail.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=dlstevens@us.ibm.com \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=ffusco@redhat.com \
--cc=hannes@stressinduktion.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=ogerlitz@mellanox.com \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).