From: Jun Zhao <mypopydev@gmail.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Cong Wang <cwang@twopensource.com>,
Pravin B Shelar <pshelar@nicira.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
stephen hemminger <stephen@networkplumber.org>,
Tom Herbert <therbert@google.com>,
netdev@vger.kernel.org, Francesco Fusco <ffusco@redhat.com>,
Veaceslav Falico <vfalico@redhat.com>,
Duan Jiong <duanj.fnst@cn.fujitsu.com>,
Jiri Pirko <jiri@resnulli.us>,
David Stevens <dlstevens@us.ibm.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Daniel Borkmann <dborkman@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] neighbour : fix ndm_type type error issue
Date: Sat, 26 Jul 2014 08:29:17 +0800 [thread overview]
Message-ID: <1406334557.5276.13.camel@popy-debian> (raw)
In-Reply-To: <1406330697.989.145785925.1CA960AF@webmail.messagingengine.com>
On Sat, 2014-07-26 at 01:24 +0200, Hannes Frederic Sowa wrote:
> On Fri, Jul 25, 2014, at 18:38, Jun Zhao wrote:
> > ndm_type means L3 address type, in neighbour proxy and vxlan, it's
> > RTN_UNICAST.
> > NDA_DST is for netlink TLV type, hence it's not right value in this
> > context.
>
> The value of NDA_DST == RTN_UNICAST, otherwise we couldn't do this
> change as it would alter e.g. arpd behavior.
>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
>
> Thanks,
> Hannes
But I think NDA_DST/RTN_UNICAST have different means in this context,
even though the value of NDA_DST == RTN_UNICAST.
For arp proxy/NDP proxy context, ndm_type means the peer L3 address,
so RTN_UNICAST is the right value. For vxlan have similar semantic for
remote ip.
BTW: In the source code, implicit think NDA_DST == RTN_UNICAST maybe
not a good idea when we don't have a comment or the other explain.
next prev parent reply other threads:[~2014-07-26 0:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 16:38 [PATCH 1/1] neighbour : fix ndm_type type error issue Jun Zhao
2014-07-25 23:21 ` Cong Wang
2014-07-25 23:24 ` Hannes Frederic Sowa
2014-07-26 0:29 ` Jun Zhao [this message]
2014-07-26 13:42 ` Hannes Frederic Sowa
2014-07-26 15:05 ` Jun Zhao
2014-07-29 0:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406334557.5276.13.camel@popy-debian \
--to=mypopydev@gmail.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=dlstevens@us.ibm.com \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=ffusco@redhat.com \
--cc=hannes@stressinduktion.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=ogerlitz@mellanox.com \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).