From: Oliver Neukum <oneukum@suse.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] cdc_subset: deal with a device that needs reset for timeout
Date: Mon, 28 Jul 2014 10:13:11 +0200 [thread overview]
Message-ID: <1406535191.17754.10.camel@linux-fkkt.site> (raw)
In-Reply-To: <20140727.223131.562363351418867070.davem@davemloft.net>
On Sun, 2014-07-27 at 22:31 -0700, David Miller wrote:
> From: Oliver Neukum <oneukum@suse.de>
> Date: Thu, 24 Jul 2014 13:59:34 +0200
>
> > @@ -1218,6 +1218,8 @@ void usbnet_tx_timeout (struct net_device *net)
> >
> > unlink_urbs (dev, &dev->txq);
> > tasklet_schedule (&dev->bh);
> > + if (dev->driver_info->recover)
> > + (dev->driver_info->recover)(dev);
> >
> > // FIXME: device recovery -- reset?
> > }
>
> Well, since you're at least providing a way to handle this now, you can
> remove this comment completely.
Certainly
Sorry
Oliver
next prev parent reply other threads:[~2014-07-28 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 11:59 [PATCH] cdc_subset: deal with a device that needs reset for timeout Oliver Neukum
2014-07-28 5:31 ` David Miller
2014-07-28 8:13 ` Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-28 8:12 Oliver Neukum
2014-07-29 19:22 ` David Miller
2014-08-01 12:01 Oliver Neukum
2014-08-02 22:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406535191.17754.10.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).