* [PATCH net] bna: fix performance regression
@ 2014-07-29 14:29 Ivan Vecera
2014-07-31 2:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Vecera @ 2014-07-29 14:29 UTC (permalink / raw)
To: netdev; +Cc: rmody
The recent commit "e29aa33 bna: Enable Multi Buffer RX" is causing
a performance regression. It does not properly update 'cmpl' pointer
at the end of the loop in NAPI handler bnad_cq_process(). The result is
only one packet / per NAPI-schedule is processed.
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/net/ethernet/brocade/bna/bnad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
index 3a77f9e..556aab7 100644
--- a/drivers/net/ethernet/brocade/bna/bnad.c
+++ b/drivers/net/ethernet/brocade/bna/bnad.c
@@ -600,9 +600,9 @@ bnad_cq_process(struct bnad *bnad, struct bna_ccb *ccb, int budget)
prefetch(bnad->netdev);
cq = ccb->sw_q;
- cmpl = &cq[ccb->producer_index];
while (packets < budget) {
+ cmpl = &cq[ccb->producer_index];
if (!cmpl->valid)
break;
/* The 'valid' field is set by the adapter, only after writing
--
1.8.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] bna: fix performance regression
2014-07-29 14:29 [PATCH net] bna: fix performance regression Ivan Vecera
@ 2014-07-31 2:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-07-31 2:10 UTC (permalink / raw)
To: ivecera; +Cc: netdev, rmody
From: Ivan Vecera <ivecera@redhat.com>
Date: Tue, 29 Jul 2014 16:29:30 +0200
> The recent commit "e29aa33 bna: Enable Multi Buffer RX" is causing
> a performance regression. It does not properly update 'cmpl' pointer
> at the end of the loop in NAPI handler bnad_cq_process(). The result is
> only one packet / per NAPI-schedule is processed.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Applied and queued up for -stable, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-31 2:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-29 14:29 [PATCH net] bna: fix performance regression Ivan Vecera
2014-07-31 2:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).