* [PATCH] bridge: remove a useless comment
@ 2014-08-04 13:22 Michael S. Tsirkin
2014-08-04 15:45 ` Stephen Hemminger
2014-08-04 19:47 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2014-08-04 13:22 UTC (permalink / raw)
To: linux-kernel; +Cc: Stephen Hemminger, netdev, bridge, David S. Miller
commit 6cbdceeb1cb12c7d620161925a8c3e81daadb2e4
bridge: Dump vlan information from a bridge port
introduced a comment in an attempt to explain the
code logic. The comment is unfinished so it confuses more
than it explains, remove it.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
net/bridge/br_netlink.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 26edb51..cb5fcf6 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -208,7 +208,6 @@ int br_getlink(struct sk_buff *skb, u32 pid, u32 seq,
int err = 0;
struct net_bridge_port *port = br_port_get_rtnl(dev);
- /* not a bridge port and */
if (!port && !(filter_mask & RTEXT_FILTER_BRVLAN))
goto out;
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bridge: remove a useless comment
2014-08-04 13:22 [PATCH] bridge: remove a useless comment Michael S. Tsirkin
@ 2014-08-04 15:45 ` Stephen Hemminger
2014-08-04 19:47 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2014-08-04 15:45 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: netdev, bridge, linux-kernel, David S. Miller
On Mon, 4 Aug 2014 15:22:40 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> commit 6cbdceeb1cb12c7d620161925a8c3e81daadb2e4
> bridge: Dump vlan information from a bridge port
> introduced a comment in an attempt to explain the
> code logic. The comment is unfinished so it confuses more
> than it explains, remove it.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bridge: remove a useless comment
2014-08-04 13:22 [PATCH] bridge: remove a useless comment Michael S. Tsirkin
2014-08-04 15:45 ` Stephen Hemminger
@ 2014-08-04 19:47 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-08-04 19:47 UTC (permalink / raw)
To: mst; +Cc: stephen, netdev, bridge, linux-kernel
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Mon, 4 Aug 2014 15:22:40 +0200
> commit 6cbdceeb1cb12c7d620161925a8c3e81daadb2e4
> bridge: Dump vlan information from a bridge port
> introduced a comment in an attempt to explain the
> code logic. The comment is unfinished so it confuses more
> than it explains, remove it.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-04 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 13:22 [PATCH] bridge: remove a useless comment Michael S. Tsirkin
2014-08-04 15:45 ` Stephen Hemminger
2014-08-04 19:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).