From: Oliver Neukum <oneukum@suse.de>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH] r8152: correct error returns
Date: Tue, 05 Aug 2014 09:43:04 +0200 [thread overview]
Message-ID: <1407224584.12844.5.camel@linux-fkkt.site> (raw)
In-Reply-To: <20140804.151827.179999106523102125.davem@davemloft.net>
On Mon, 2014-08-04 at 15:18 -0700, David Miller wrote:
> From: Oliver Neukum <oneukum@suse.de>
> Date: Sun, 03 Aug 2014 09:06:58 +0200
>
> > OK, I just looked at this single driver. I'll try to come up with
> > a generic solution. The mapping is a bit simplistic. I should let
> > -ENOMEM pass for example.
>
> And the problem also isn't limited USB networking drivers, just
> about every driver I looked at passed these autopm errors right
> back to userspace.
I drilled a gas bubble.
> Largely people just call the autopm interfaces and propagate any
> errors they get. So you probably want to put the translator/filter
> there.
That would swallow up all error returns and hurt the users who actually
use the error codes. How about a native and a sanitized
version?
> But of course, that doesn't handle the non-autopm code paths into the
> PM layer that can end up in this situation.
Hm. Are they numerous? Which did you find?
Regards
Oliver
next prev parent reply other threads:[~2014-08-05 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 13:56 [PATCH] r8152: correct error returns Oliver Neukum
2014-08-02 23:34 ` David Miller
2014-08-03 7:06 ` Oliver Neukum
2014-08-04 22:18 ` David Miller
2014-08-05 7:43 ` Oliver Neukum [this message]
2014-08-05 19:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407224584.12844.5.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).