From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: [PATCH v3 2/3] cxgb4: use module_long_probe_init() Date: Tue, 12 Aug 2014 15:28:26 -0700 Message-ID: <1407882507-325-3-git-send-email-mcgrof@do-not-panic.com> References: <1407882507-325-1-git-send-email-mcgrof@do-not-panic.com> Cc: tiwai@suse.de, linux-kernel@vger.kernel.org, "Luis R. Rodriguez" , Tetsuo Handa , Joseph Salisbury , One Thousand Gnomes , Tim Gardner , Pierre Fersing , Andrew Morton , Oleg Nesterov , Benjamin Poirier , Nagalakshmi Nandigama , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan , Hariprasad S , Santosh Rastapur , MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, netdev@vger.kernel.org To: gregkh@linuxfoundation.org Return-path: In-Reply-To: <1407882507-325-1-git-send-email-mcgrof@do-not-panic.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: "Luis R. Rodriguez" cxgb4 probe can take up to over 1 minute when the firmware is is written and installed on the device, even after this the device driver still does some device probing and can take quite a bit. This driver needs fixing but right now it simply wont' work on some systems. Use the new module_long_probe_init() to annotate this driver's probe is broken and require some love, but makes the driver operational until that is fixed. Cc: Tetsuo Handa Cc: Joseph Salisbury Cc: One Thousand Gnomes Cc: Tim Gardner Cc: Pierre Fersing Cc: Andrew Morton Cc: Oleg Nesterov Cc: Benjamin Poirier Cc: Greg Kroah-Hartman Cc: Nagalakshmi Nandigama Cc: Praveen Krishnamoorthy Cc: Sreekanth Reddy Cc: Abhijit Mahajan Cc: Hariprasad S Cc: Santosh Rastapur Cc: MPT-FusionLinux.pdl@avagotech.com Cc: linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Luis R. Rodriguez --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 36ebbda..5d8231d 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -34,6 +34,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include #include #include #include @@ -6815,5 +6816,5 @@ static void __exit cxgb4_cleanup_module(void) destroy_workqueue(workq); } -module_init(cxgb4_init_module); -module_exit(cxgb4_cleanup_module); +module_long_probe_init(cxgb4_init_module); +module_long_probe_exit(cxgb4_cleanup_module); -- 2.0.3