From mboxrd@z Thu Jan 1 00:00:00 1970 From: Govindarajulu Varadarajan <_govind@gmx.com> Subject: [PATCH net-next] tg3: fix return value in tg3_get_stats64 Date: Wed, 13 Aug 2014 13:04:56 +0530 Message-ID: <1407915296-12692-1-git-send-email-_govind@gmx.com> Cc: Govindarajulu Varadarajan <_govind@gmx.com> To: davem@davemloft.net, prashant@broadcom.com, mchan@broadcom.com, netdev@vger.kernel.org Return-path: Received: from mout.gmx.com ([74.208.4.201]:53939 "EHLO mout.gmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbaHMHfW (ORCPT ); Wed, 13 Aug 2014 03:35:22 -0400 Sender: netdev-owner@vger.kernel.org List-ID: When tp->hw_stats is 0, tg3_get_stats64 should display previously recorded stats. So it returns &tp->net_stats_prev. But the caller, dev_get_stats, ignores the return value. Fix this by assigning tp->net_stats_prev to stats and returning stats. Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com> --- drivers/net/ethernet/broadcom/tg3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index a3dd5dc..4296b3d26 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -14093,8 +14093,9 @@ static struct rtnl_link_stats64 *tg3_get_stats64(struct net_device *dev, spin_lock_bh(&tp->lock); if (!tp->hw_stats) { + *stats = tp->net_stats_prev; spin_unlock_bh(&tp->lock); - return &tp->net_stats_prev; + return stats; } tg3_get_nstats(tp, stats); -- 2.0.4